[RFC,v1,36/54] libcamera: request: completeBuffer(): Emit `bufferCompleted` last
diff mbox series

Message ID 20260629163017.863145-37-barnabas.pocze@ideasonboard.com
State New
Headers show
Series
  • libcamera: Split requests and buffers
Related show

Commit Message

Barnabás Pőcze June 29, 2026, 4:29 p.m. UTC 
To ensure that the application can see the buffer in the request's
buffer map.

Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
---
 src/libcamera/request.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Patch
diff mbox series 

diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp
index d7cf39ae2e..ecdf558066 100644
--- a/src/libcamera/request.cpp
+++ b/src/libcamera/request.cpp
@@ -108,8 +108,6 @@  bool Request::Private::completeBuffer(FrameBuffer *buffer)
 	LIBCAMERA_TRACEPOINT(request_complete_buffer, this, buffer);
 
 	Request *request = LIBCAMERA_O_PTR();
-	camera_->bufferCompleted.emit(request, buffer);
-
 	auto it = request->bufferMap_.find(buffer->_d()->stream_);
 	ASSERT(it != request->bufferMap_.end());
 	ASSERT(it->second == buffer || !it->second);
@@ -124,6 +122,8 @@  bool Request::Private::completeBuffer(FrameBuffer *buffer)
 	if (buffer->metadata().status == FrameMetadata::FrameCancelled)
 		cancelled_ = true;
 
+	camera_->bufferCompleted.emit(request, buffer);
+
 	return !hasPendingBuffers();
 }