[RFC,v1,18/54] libcamera: request: Remove `ReuseBuffers`
diff mbox series

Message ID 20260629163017.863145-19-barnabas.pocze@ideasonboard.com
State New
Headers show
Series
  • libcamera: Split requests and buffers
Related show

Commit Message

Barnabás Pőcze June 29, 2026, 4:29 p.m. UTC
Remove the implementation of the `ReuseBuffers` flag. With the split
of requests and buffers, it is no longer that useful, and having it
work in any reasonable capacity requires more compatibility code.

For now only the implementation is removed.

Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
---
 src/libcamera/request.cpp | 13 ++++---------
 1 file changed, 4 insertions(+), 9 deletions(-)

Patch
diff mbox series

diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp
index 022a97f169..b1a81e36ef 100644
--- a/src/libcamera/request.cpp
+++ b/src/libcamera/request.cpp
@@ -390,17 +390,12 @@  void Request::reuse(ReuseFlag flags)
 {
 	LIBCAMERA_TRACEPOINT(request_reuse, this);
 
-	_d()->reset();
+	if (flags)
+		LOG(Request, Fatal) << "NOT IMPLEMENTED";
 
-	if (flags & ReuseBuffers) {
-		for (const auto &[stream, buffer] : bufferMap_) {
-			buffer->_d()->setRequest(this);
-			_d()->pending_.insert(buffer);
-		}
-	} else {
-		bufferMap_.clear();
-	}
+	_d()->reset();
 
+	bufferMap_.clear();
 	status_ = RequestPending;
 
 	controls_.clear();