[RFC,v1,48/54] libcamera: request: Remove `ReuseFlag`

27127 diff mbox series

diff --git a/Documentation/guides/application-developer.rst b/Documentation/guides/application-developer.rst
index a9620ca862..9c6191406d 100644
--- a/Documentation/guides/application-developer.rst
+++ b/Documentation/guides/application-developer.rst
@@ -477,15 +477,6 @@  libcamera repository.
 
 .. _FileSink class: https://git.libcamera.org/libcamera/libcamera.git/tree/src/apps/cam/file_sink.cpp
 
-With the handling of this request completed, it is possible to re-use the
-request and the associated buffers and re-queue it to the camera
-device:
-
-.. code:: cpp
-
-   request->reuse(Request::ReuseBuffers);
-   camera->queueRequest(request);
-
 Request queueing
 ----------------
 
diff --git a/include/libcamera/request.h b/include/libcamera/request.h
index c86259c59b..462611da59 100644
--- a/include/libcamera/request.h
+++ b/include/libcamera/request.h
@@ -37,17 +37,12 @@  public:
 		RequestCancelled,
 	};
 
-	enum ReuseFlag {
-		Default = 0,
-		ReuseBuffers = (1 << 0),
-	};
-
 	using BufferMap = std::map<const Stream *, FrameBuffer *>;
 
 	Request(Camera *camera, uint64_t cookie = 0);
 	~Request();
 
-	void reuse(ReuseFlag flags = Default);
+	void reuse();
 
 	ControlList &controls() { return controls_; }
 	const ControlList &metadata() const;
diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp
index 4fb8c0a659..5d28ac80df 100644
--- a/src/libcamera/request.cpp
+++ b/src/libcamera/request.cpp
@@ -193,18 +193,6 @@  void Request::Private::reset()
  * The request has been cancelled due to capture stop
  */
 
-/**
- * \enum Request::ReuseFlag
- * Flags to control the behavior of Request::reuse()
- * \var Request::Default
- * Don't reuse buffers
- * \var Request::ReuseBuffers
- * Reuse the buffers that were previously added by addBuffer()
- *
- * \note Fences associated with the buffers are not reused.
- *  This flag should not be used if fences are used.
- */
-
 /**
  * \typedef Request::BufferMap
  * \brief A map of Stream to FrameBuffer pointers
@@ -245,21 +233,16 @@  Request::~Request()
 
 /**
  * \brief Reset the request for reuse
- * \param[in] flags Indicate whether or not to reuse the buffers
  *
  * Reset the status and controls associated with the request, to allow it to
  * be reused and requeued without destruction. This function shall be called
  * prior to queueing the request to the camera, in lieu of constructing a new
- * request. The application can reuse the buffers that were previously added
- * to the request via addBuffer() by setting \a flags to ReuseBuffers.
+ * request.
  */
-void Request::reuse(ReuseFlag flags)
+void Request::reuse()
 {
 	LIBCAMERA_TRACEPOINT(request_reuse, this);
 
-	if (flags)
-		LOG(Request, Fatal) << "NOT IMPLEMENTED";
-
 	_d()->reset();
 
 	bufferMap_.clear();
diff --git a/src/py/libcamera/py_main.cpp b/src/py/libcamera/py_main.cpp
index 26b348ef0e..7196bb0f6d 100644
--- a/src/py/libcamera/py_main.cpp
+++ b/src/py/libcamera/py_main.cpp
@@ -135,7 +135,6 @@  PYBIND11_MODULE(_libcamera, m)
 	auto pyControlInfo = py::class_<ControlInfo>(m, "ControlInfo");
 	auto pyRequest = py::class_<Request, std::unique_ptr<Request, RequestDeleter>>(m, "Request");
 	auto pyRequestStatus = py::enum_<Request::Status>(pyRequest, "Status");
-	auto pyRequestReuse = py::enum_<Request::ReuseFlag>(pyRequest, "Reuse");
 	auto pyFrameMetadata = py::class_<FrameMetadata>(m, "FrameMetadata");
 	auto pyFrameMetadataStatus = py::enum_<FrameMetadata::Status>(pyFrameMetadata, "Status");
 	auto pyFrameMetadataPlane = py::class_<FrameMetadata::Plane>(pyFrameMetadata, "Plane");