[RFC,v1,04/54] libcamera: pipeline: mali-c55: Remove `setRequest()` calls
diff mbox series

Message ID 20260629163017.863145-5-barnabas.pocze@ideasonboard.com
State New
Headers show
Series
  • libcamera: Split requests and buffers
Related show

Commit Message

Barnabás Pőcze June 29, 2026, 4:29 p.m. UTC 
The buffer completion handler (`PipelineHandlerMaliC55::cruBufferReady()`)
does not query the request of the buffer, so setting it is unnecessary.

Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
---
 src/libcamera/pipeline/mali-c55/mali-c55.cpp  | 2 +-
 src/libcamera/pipeline/mali-c55/rzg2l-cru.cpp | 3 +--
 src/libcamera/pipeline/mali-c55/rzg2l-cru.h   | 3 +--
 3 files changed, 3 insertions(+), 5 deletions(-)

Patch
diff mbox series 

diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp
index 599ff88b59..b30455683e 100644
--- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp
+++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp
@@ -1541,7 +1541,7 @@  void PipelineHandlerMaliC55::queueRequestToCru(MaliC55CameraData *data,
 	auto *mem = std::get_if<MaliC55CameraData::Memory>(&data->input_);
 	ASSERT(mem);
 
-	FrameBuffer *cruBuffer = mem->cru_->queueBuffer(request);
+	FrameBuffer *cruBuffer = mem->cru_->queueBuffer();
 	ASSERT(cruBuffer);
 
 	auto frameInfo = prepareFrameInfo(request);
diff --git a/src/libcamera/pipeline/mali-c55/rzg2l-cru.cpp b/src/libcamera/pipeline/mali-c55/rzg2l-cru.cpp
index 9cb7cc3f10..3de4527561 100644
--- a/src/libcamera/pipeline/mali-c55/rzg2l-cru.cpp
+++ b/src/libcamera/pipeline/mali-c55/rzg2l-cru.cpp
@@ -35,7 +35,7 @@  static const std::map<uint8_t, V4L2PixelFormat> bitDepthToFmt{
 
 LOG_DEFINE_CATEGORY(RZG2LCRU)
 
-FrameBuffer *RZG2LCRU::queueBuffer(Request *request)
+FrameBuffer *RZG2LCRU::queueBuffer()
 {
 	FrameBuffer *buffer;
 
@@ -53,7 +53,6 @@  FrameBuffer *RZG2LCRU::queueBuffer(Request *request)
 	}
 
 	availableBuffers_.pop_back();
-	buffer->_d()->setRequest(request);
 
 	return buffer;
 }
diff --git a/src/libcamera/pipeline/mali-c55/rzg2l-cru.h b/src/libcamera/pipeline/mali-c55/rzg2l-cru.h
index 8bd4c027ad..7ef5e2b5ee 100644
--- a/src/libcamera/pipeline/mali-c55/rzg2l-cru.h
+++ b/src/libcamera/pipeline/mali-c55/rzg2l-cru.h
@@ -20,7 +20,6 @@  namespace libcamera {
 class CameraSensor;
 class FrameBuffer;
 class MediaDevice;
-class Request;
 class Size;
 
 class RZG2LCRU
@@ -45,7 +44,7 @@  public:
 	V4L2VideoDevice *output() { return output_.get(); }
 
 	int configure(V4L2SubdeviceFormat *subdevFormat, V4L2DeviceFormat *inputFormat);
-	FrameBuffer *queueBuffer(Request *request);
+	FrameBuffer *queueBuffer();
 	void returnBuffer(FrameBuffer *buffer);
 	int freeBuffers();