From patchwork Mon Jun 29 16:29:27 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= X-Patchwork-Id: 27083 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id C6E8FC3261 for ; Mon, 29 Jun 2026 16:30:42 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 5767F65F61; Mon, 29 Jun 2026 18:30:29 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="TAfeecM+"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 8DB5065F04 for ; Mon, 29 Jun 2026 18:30:21 +0200 (CEST) Received: from pb-laptop.local (185.221.140.128.nat.pool.zt.hu [185.221.140.128]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 6EF03E91 for ; Mon, 29 Jun 2026 18:29:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1782750578; bh=PuZgyyAqywl0ytorJi6f1SdmjAFzOagjt5FkHhiy9aw=; h=From:To:Subject:Date:In-Reply-To:References:From; b=TAfeecM+zOBxBP6l9c+4A96nJJPhzBzVst6uvsnAcvsKlg4N4bn32VbYnZXWHVpGi z2l9Wz6sD561EvhbxHndAjYQQXq+lCrnDbQrjUTLdC++AgebqvSnwSwiQXgwVQ5y5j jVgu0qe+IX33I8z20v5cmT5dQLFkb7Sqi3MExVLQ= From: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= To: libcamera-devel@lists.libcamera.org Subject: [RFC PATCH v1 04/54] libcamera: pipeline: mali-c55: Remove `setRequest()` calls Date: Mon, 29 Jun 2026 18:29:27 +0200 Message-ID: <20260629163017.863145-5-barnabas.pocze@ideasonboard.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260629163017.863145-1-barnabas.pocze@ideasonboard.com> References: <20260629163017.863145-1-barnabas.pocze@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The buffer completion handler (`PipelineHandlerMaliC55::cruBufferReady()`) does not query the request of the buffer, so setting it is unnecessary. Signed-off-by: Barnabás Pőcze --- src/libcamera/pipeline/mali-c55/mali-c55.cpp | 2 +- src/libcamera/pipeline/mali-c55/rzg2l-cru.cpp | 3 +-- src/libcamera/pipeline/mali-c55/rzg2l-cru.h | 3 +-- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp index 599ff88b59..b30455683e 100644 --- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp +++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp @@ -1541,7 +1541,7 @@ void PipelineHandlerMaliC55::queueRequestToCru(MaliC55CameraData *data, auto *mem = std::get_if(&data->input_); ASSERT(mem); - FrameBuffer *cruBuffer = mem->cru_->queueBuffer(request); + FrameBuffer *cruBuffer = mem->cru_->queueBuffer(); ASSERT(cruBuffer); auto frameInfo = prepareFrameInfo(request); diff --git a/src/libcamera/pipeline/mali-c55/rzg2l-cru.cpp b/src/libcamera/pipeline/mali-c55/rzg2l-cru.cpp index 9cb7cc3f10..3de4527561 100644 --- a/src/libcamera/pipeline/mali-c55/rzg2l-cru.cpp +++ b/src/libcamera/pipeline/mali-c55/rzg2l-cru.cpp @@ -35,7 +35,7 @@ static const std::map bitDepthToFmt{ LOG_DEFINE_CATEGORY(RZG2LCRU) -FrameBuffer *RZG2LCRU::queueBuffer(Request *request) +FrameBuffer *RZG2LCRU::queueBuffer() { FrameBuffer *buffer; @@ -53,7 +53,6 @@ FrameBuffer *RZG2LCRU::queueBuffer(Request *request) } availableBuffers_.pop_back(); - buffer->_d()->setRequest(request); return buffer; } diff --git a/src/libcamera/pipeline/mali-c55/rzg2l-cru.h b/src/libcamera/pipeline/mali-c55/rzg2l-cru.h index 8bd4c027ad..7ef5e2b5ee 100644 --- a/src/libcamera/pipeline/mali-c55/rzg2l-cru.h +++ b/src/libcamera/pipeline/mali-c55/rzg2l-cru.h @@ -20,7 +20,6 @@ namespace libcamera { class CameraSensor; class FrameBuffer; class MediaDevice; -class Request; class Size; class RZG2LCRU @@ -45,7 +44,7 @@ public: V4L2VideoDevice *output() { return output_.get(); } int configure(V4L2SubdeviceFormat *subdevFormat, V4L2DeviceFormat *inputFormat); - FrameBuffer *queueBuffer(Request *request); + FrameBuffer *queueBuffer(); void returnBuffer(FrameBuffer *buffer); int freeBuffers();