[RFC,v1,02/54] libcamera: request: Disassociate buffer when cancelling
diff mbox series

Message ID 20260629163017.863145-3-barnabas.pocze@ideasonboard.com
State New
Headers show
Series
  • libcamera: Split requests and buffers
Related show

Commit Message

Barnabás Pőcze June 29, 2026, 4:29 p.m. UTC 
Match the behaviour of `completeBuffer()` by unsetting the "parent" `Request`
pointer of the `FrameBuffer`.

Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 src/libcamera/request.cpp | 1 +
 1 file changed, 1 insertion(+)

Patch
diff mbox series 

diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp
index 163d8cf920..5f983e0ce6 100644
--- a/src/libcamera/request.cpp
+++ b/src/libcamera/request.cpp
@@ -143,6 +143,7 @@  void Request::Private::doCancelRequest()
 	for (FrameBuffer *buffer : pending_) {
 		buffer->_d()->cancel();
 		camera_->bufferCompleted.emit(request, buffer);
+		buffer->_d()->setRequest(nullptr);
 	}
 
 	cancelled_ = true;