From patchwork Mon Jun 29 16:29:25 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= X-Patchwork-Id: 27081 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id CAC59C3261 for ; Mon, 29 Jun 2026 16:30:37 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 26C8865F31; Mon, 29 Jun 2026 18:30:27 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="O/n1U1Ic"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 29DF065F21 for ; Mon, 29 Jun 2026 18:30:21 +0200 (CEST) Received: from pb-laptop.local (185.221.140.128.nat.pool.zt.hu [185.221.140.128]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id D50101044; Mon, 29 Jun 2026 18:29:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1782750578; bh=so6WTDiZP0Yg9iTDyJ0AArtYlJl8k5aH4ItHX611/0k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=O/n1U1IcXyAfw4fow2+HIE1GHBgiVKKErqtMxBv1jgwRkfN+vdaVqmn27ysyVdHQX T4WNg71b3n+VMhmRj0p4Hi8T6zddgKniAreTMKFljY+OM4AX1kQYIzXDv77gd8LyKY Ey67K4ZuLXCN6Hig1EdR3yDnXoorwZ0k9XYGYNNY= From: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= To: libcamera-devel@lists.libcamera.org Cc: Jacopo Mondi , Laurent Pinchart Subject: [RFC PATCH v1 02/54] libcamera: request: Disassociate buffer when cancelling Date: Mon, 29 Jun 2026 18:29:25 +0200 Message-ID: <20260629163017.863145-3-barnabas.pocze@ideasonboard.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260629163017.863145-1-barnabas.pocze@ideasonboard.com> References: <20260629163017.863145-1-barnabas.pocze@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Match the behaviour of `completeBuffer()` by unsetting the "parent" `Request` pointer of the `FrameBuffer`. Signed-off-by: Barnabás Pőcze Reviewed-by: Jacopo Mondi Reviewed-by: Laurent Pinchart --- src/libcamera/request.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp index 163d8cf920..5f983e0ce6 100644 --- a/src/libcamera/request.cpp +++ b/src/libcamera/request.cpp @@ -143,6 +143,7 @@ void Request::Private::doCancelRequest() for (FrameBuffer *buffer : pending_) { buffer->_d()->cancel(); camera_->bufferCompleted.emit(request, buffer); + buffer->_d()->setRequest(nullptr); } cancelled_ = true;