From patchwork Mon Jun 29 16:29:41 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= X-Patchwork-Id: 27097 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 4A098C3261 for ; Mon, 29 Jun 2026 16:31:06 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id D192165F48; Mon, 29 Jun 2026 18:30:55 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="N9O2Ndy5"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 238EE65F41 for ; Mon, 29 Jun 2026 18:30:25 +0200 (CEST) Received: from pb-laptop.local (185.221.140.128.nat.pool.zt.hu [185.221.140.128]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 023C98D4 for ; Mon, 29 Jun 2026 18:29:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1782750582; bh=CsaT+i0oyShur8yb1g7Oy/M68CtcBChxeQYfFmNsOX8=; h=From:To:Subject:Date:In-Reply-To:References:From; b=N9O2Ndy5uTU/9/ozwkOVFIMKlrCqm9lY+iTdnGCvOYxd12erMcZf8yhPrlD0iA2Re GGTe3BB+lpdhMCaI3Let+hTa8P0IsSBK0XMIB4+fL5pGQBg/dqS2YECFNisWxnIe/1 4kdRfxntDneaetVGAsCUuuFRvtGU5R2UNQAsOBvc= From: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= To: libcamera-devel@lists.libcamera.org Subject: [RFC PATCH v1 18/54] libcamera: request: Remove `ReuseBuffers` Date: Mon, 29 Jun 2026 18:29:41 +0200 Message-ID: <20260629163017.863145-19-barnabas.pocze@ideasonboard.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260629163017.863145-1-barnabas.pocze@ideasonboard.com> References: <20260629163017.863145-1-barnabas.pocze@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Remove the implementation of the `ReuseBuffers` flag. With the split of requests and buffers, it is no longer that useful, and having it work in any reasonable capacity requires more compatibility code. For now only the implementation is removed. Signed-off-by: Barnabás Pőcze --- src/libcamera/request.cpp | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp index 022a97f169..b1a81e36ef 100644 --- a/src/libcamera/request.cpp +++ b/src/libcamera/request.cpp @@ -390,17 +390,12 @@ void Request::reuse(ReuseFlag flags) { LIBCAMERA_TRACEPOINT(request_reuse, this); - _d()->reset(); + if (flags) + LOG(Request, Fatal) << "NOT IMPLEMENTED"; - if (flags & ReuseBuffers) { - for (const auto &[stream, buffer] : bufferMap_) { - buffer->_d()->setRequest(this); - _d()->pending_.insert(buffer); - } - } else { - bufferMap_.clear(); - } + _d()->reset(); + bufferMap_.clear(); status_ = RequestPending; controls_.clear();