From patchwork Mon Jun 29 16:29:59 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= X-Patchwork-Id: 27115 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id CA933C3261 for ; Mon, 29 Jun 2026 16:31:27 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 6F91465F96; Mon, 29 Jun 2026 18:31:27 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="kDObMemi"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 0071865F60 for ; Mon, 29 Jun 2026 18:30:29 +0200 (CEST) Received: from pb-laptop.local (185.221.140.128.nat.pool.zt.hu [185.221.140.128]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id D034E1044 for ; Mon, 29 Jun 2026 18:29:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1782750585; bh=mNPadciu9eF3j/cPMIbZCENrQJr8XUSe8TAg7lA7gMs=; h=From:To:Subject:Date:In-Reply-To:References:From; b=kDObMemiboYftLsRocaOla0OquvBUMW9GkgEA4lYavRx9MkI5MEo9QY18x0SAjjzI l87iCwldWmwG6sP0vwcu2V+iN5/2YJukgf1qR3V7J3lRod14Oox20MuduRti8Jv41E nQhIMcEt43IbCuV+MRGYAD2KHl/CDf1C2wOSoxi8= From: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= To: libcamera-devel@lists.libcamera.org Subject: [RFC PATCH v1 36/54] libcamera: request: completeBuffer(): Emit `bufferCompleted` last Date: Mon, 29 Jun 2026 18:29:59 +0200 Message-ID: <20260629163017.863145-37-barnabas.pocze@ideasonboard.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260629163017.863145-1-barnabas.pocze@ideasonboard.com> References: <20260629163017.863145-1-barnabas.pocze@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" To ensure that the application can see the buffer in the request's buffer map. Signed-off-by: Barnabás Pőcze --- src/libcamera/request.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp index d7cf39ae2e..ecdf558066 100644 --- a/src/libcamera/request.cpp +++ b/src/libcamera/request.cpp @@ -108,8 +108,6 @@ bool Request::Private::completeBuffer(FrameBuffer *buffer) LIBCAMERA_TRACEPOINT(request_complete_buffer, this, buffer); Request *request = LIBCAMERA_O_PTR(); - camera_->bufferCompleted.emit(request, buffer); - auto it = request->bufferMap_.find(buffer->_d()->stream_); ASSERT(it != request->bufferMap_.end()); ASSERT(it->second == buffer || !it->second); @@ -124,6 +122,8 @@ bool Request::Private::completeBuffer(FrameBuffer *buffer) if (buffer->metadata().status == FrameMetadata::FrameCancelled) cancelled_ = true; + camera_->bufferCompleted.emit(request, buffer); + return !hasPendingBuffers(); }