[RFC,v1,06/17] ipa: rkisp1: Update sensor info when configuring
diff mbox series

Message ID 20260703153819.1088752-7-barnabas.pocze@ideasonboard.com
State Superseded
Headers show
Series
  • ipa: libipa: agc rework
Related show

Commit Message

Barnabás Pőcze July 3, 2026, 3:38 p.m. UTC 
830340615afd ("ipa: rkisp1: Add sensor info to context") added the sensor
info to the `IPAContext` type, but it only updates it in `init()`, do it
in configure as well.

Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
---
 src/ipa/rkisp1/rkisp1.cpp | 1 +
 1 file changed, 1 insertion(+)

Comments

Kieran Bingham July 4, 2026, 5:11 a.m. UTC | #1 
Quoting Barnabás Pőcze (2026-07-03 16:38:08)
> 830340615afd ("ipa: rkisp1: Add sensor info to context") added the sensor
> info to the `IPAContext` type, but it only updates it in `init()`, do it
> in configure as well.
> 
> Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
> ---
>  src/ipa/rkisp1/rkisp1.cpp | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp
> index 9f1f133e6f..b31d5b59a8 100644
> --- a/src/ipa/rkisp1/rkisp1.cpp
> +++ b/src/ipa/rkisp1/rkisp1.cpp
> @@ -225,6 +225,7 @@ int IPARkISP1::configure(const IPAConfigInfo &ipaConfig,
>                          const std::map<uint32_t, IPAStream> &streamConfig,
>                          ControlInfoMap *ipaControls)
>  {
> +       context_.sensorInfo = ipaConfig.sensorInfo;

Curious, Stefan have you ever hit this ?

Anyway - it looks like something we should update after configure
indeed:


Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

>         context_.sensorControls = ipaConfig.sensorControls;
>  
>         const auto itExp = context_.sensorControls.find(V4L2_CID_EXPOSURE);
> -- 
> 2.54.0
>
Jacopo Mondi July 15, 2026, 3:44 p.m. UTC | #2 
Hi Barnabás

On Fri, Jul 03, 2026 at 05:38:08PM +0200, Barnabás Pőcze wrote:
> 830340615afd ("ipa: rkisp1: Add sensor info to context") added the sensor
> info to the `IPAContext` type, but it only updates it in `init()`, do it
> in configure as well.

weird we didn't notice :/

Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>

>
> Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
> ---
>  src/ipa/rkisp1/rkisp1.cpp | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp
> index 9f1f133e6f..b31d5b59a8 100644
> --- a/src/ipa/rkisp1/rkisp1.cpp
> +++ b/src/ipa/rkisp1/rkisp1.cpp
> @@ -225,6 +225,7 @@ int IPARkISP1::configure(const IPAConfigInfo &ipaConfig,
>  			 const std::map<uint32_t, IPAStream> &streamConfig,
>  			 ControlInfoMap *ipaControls)
>  {
> +	context_.sensorInfo = ipaConfig.sensorInfo;
>  	context_.sensorControls = ipaConfig.sensorControls;
>
>  	const auto itExp = context_.sensorControls.find(V4L2_CID_EXPOSURE);
> --
> 2.54.0
>

Patch
diff mbox series 

diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp
index 9f1f133e6f..b31d5b59a8 100644
--- a/src/ipa/rkisp1/rkisp1.cpp
+++ b/src/ipa/rkisp1/rkisp1.cpp
@@ -225,6 +225,7 @@  int IPARkISP1::configure(const IPAConfigInfo &ipaConfig,
 			 const std::map<uint32_t, IPAStream> &streamConfig,
 			 ControlInfoMap *ipaControls)
 {
+	context_.sensorInfo = ipaConfig.sensorInfo;
 	context_.sensorControls = ipaConfig.sensorControls;
 
 	const auto itExp = context_.sensorControls.find(V4L2_CID_EXPOSURE);