| Message ID | 20260703153819.1088752-3-barnabas.pocze@ideasonboard.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series |
|
| Related | show |
Quoting Barnabás Pőcze (2026-07-03 16:38:04) > It is not used, so remove it. Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com> > --- > src/ipa/rkisp1/ipa_context.cpp | 3 --- > src/ipa/rkisp1/ipa_context.h | 1 - > src/ipa/rkisp1/rkisp1.cpp | 2 -- > 3 files changed, 6 deletions(-) > > diff --git a/src/ipa/rkisp1/ipa_context.cpp b/src/ipa/rkisp1/ipa_context.cpp > index f9d0aff058..302b4cfd70 100644 > --- a/src/ipa/rkisp1/ipa_context.cpp > +++ b/src/ipa/rkisp1/ipa_context.cpp > @@ -98,9 +98,6 @@ namespace libcamera::ipa::rkisp1 { > * \var IPASessionConfiguration::sensor.maxAnalogueGain > * \brief Maximum analogue gain supported with the sensor > * > - * \var IPASessionConfiguration::sensor.defVBlank > - * \brief The default vblank value of the sensor > - * > * \var IPASessionConfiguration::sensor.lineDuration > * \brief Line duration in microseconds > * > diff --git a/src/ipa/rkisp1/ipa_context.h b/src/ipa/rkisp1/ipa_context.h > index e5f70d934d..9a4e0f12c6 100644 > --- a/src/ipa/rkisp1/ipa_context.h > +++ b/src/ipa/rkisp1/ipa_context.h > @@ -68,7 +68,6 @@ struct IPASessionConfiguration { > double minAnalogueGain; > double maxAnalogueGain; > > - int32_t defVBlank; > utils::Duration lineDuration; > Size size; > } sensor; > diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp > index 58ef163d85..273540a330 100644 > --- a/src/ipa/rkisp1/rkisp1.cpp > +++ b/src/ipa/rkisp1/rkisp1.cpp > @@ -249,8 +249,6 @@ int IPARkISP1::configure(const IPAConfigInfo &ipaConfig, > context_.configuration.paramFormat = ipaConfig.paramFormat; > > const IPACameraSensorInfo &info = ipaConfig.sensorInfo; > - const ControlInfo vBlank = sensorControls_.find(V4L2_CID_VBLANK)->second; > - context_.configuration.sensor.defVBlank = vBlank.def().get<int32_t>(); > context_.configuration.sensor.size = info.outputSize; > context_.configuration.sensor.lineDuration = info.minLineLength * 1.0s / info.pixelRate; > > -- > 2.54.0 >
Hi Barnabás On Fri, Jul 03, 2026 at 05:38:04PM +0200, Barnabás Pőcze wrote: > It is not used, so remove it. > > Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com> Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> > --- > src/ipa/rkisp1/ipa_context.cpp | 3 --- > src/ipa/rkisp1/ipa_context.h | 1 - > src/ipa/rkisp1/rkisp1.cpp | 2 -- > 3 files changed, 6 deletions(-) > > diff --git a/src/ipa/rkisp1/ipa_context.cpp b/src/ipa/rkisp1/ipa_context.cpp > index f9d0aff058..302b4cfd70 100644 > --- a/src/ipa/rkisp1/ipa_context.cpp > +++ b/src/ipa/rkisp1/ipa_context.cpp > @@ -98,9 +98,6 @@ namespace libcamera::ipa::rkisp1 { > * \var IPASessionConfiguration::sensor.maxAnalogueGain > * \brief Maximum analogue gain supported with the sensor > * > - * \var IPASessionConfiguration::sensor.defVBlank > - * \brief The default vblank value of the sensor > - * > * \var IPASessionConfiguration::sensor.lineDuration > * \brief Line duration in microseconds > * > diff --git a/src/ipa/rkisp1/ipa_context.h b/src/ipa/rkisp1/ipa_context.h > index e5f70d934d..9a4e0f12c6 100644 > --- a/src/ipa/rkisp1/ipa_context.h > +++ b/src/ipa/rkisp1/ipa_context.h > @@ -68,7 +68,6 @@ struct IPASessionConfiguration { > double minAnalogueGain; > double maxAnalogueGain; > > - int32_t defVBlank; > utils::Duration lineDuration; > Size size; > } sensor; > diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp > index 58ef163d85..273540a330 100644 > --- a/src/ipa/rkisp1/rkisp1.cpp > +++ b/src/ipa/rkisp1/rkisp1.cpp > @@ -249,8 +249,6 @@ int IPARkISP1::configure(const IPAConfigInfo &ipaConfig, > context_.configuration.paramFormat = ipaConfig.paramFormat; > > const IPACameraSensorInfo &info = ipaConfig.sensorInfo; > - const ControlInfo vBlank = sensorControls_.find(V4L2_CID_VBLANK)->second; > - context_.configuration.sensor.defVBlank = vBlank.def().get<int32_t>(); > context_.configuration.sensor.size = info.outputSize; > context_.configuration.sensor.lineDuration = info.minLineLength * 1.0s / info.pixelRate; > > -- > 2.54.0 >
diff --git a/src/ipa/rkisp1/ipa_context.cpp b/src/ipa/rkisp1/ipa_context.cpp index f9d0aff058..302b4cfd70 100644 --- a/src/ipa/rkisp1/ipa_context.cpp +++ b/src/ipa/rkisp1/ipa_context.cpp @@ -98,9 +98,6 @@ namespace libcamera::ipa::rkisp1 { * \var IPASessionConfiguration::sensor.maxAnalogueGain * \brief Maximum analogue gain supported with the sensor * - * \var IPASessionConfiguration::sensor.defVBlank - * \brief The default vblank value of the sensor - * * \var IPASessionConfiguration::sensor.lineDuration * \brief Line duration in microseconds * diff --git a/src/ipa/rkisp1/ipa_context.h b/src/ipa/rkisp1/ipa_context.h index e5f70d934d..9a4e0f12c6 100644 --- a/src/ipa/rkisp1/ipa_context.h +++ b/src/ipa/rkisp1/ipa_context.h @@ -68,7 +68,6 @@ struct IPASessionConfiguration { double minAnalogueGain; double maxAnalogueGain; - int32_t defVBlank; utils::Duration lineDuration; Size size; } sensor; diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp index 58ef163d85..273540a330 100644 --- a/src/ipa/rkisp1/rkisp1.cpp +++ b/src/ipa/rkisp1/rkisp1.cpp @@ -249,8 +249,6 @@ int IPARkISP1::configure(const IPAConfigInfo &ipaConfig, context_.configuration.paramFormat = ipaConfig.paramFormat; const IPACameraSensorInfo &info = ipaConfig.sensorInfo; - const ControlInfo vBlank = sensorControls_.find(V4L2_CID_VBLANK)->second; - context_.configuration.sensor.defVBlank = vBlank.def().get<int32_t>(); context_.configuration.sensor.size = info.outputSize; context_.configuration.sensor.lineDuration = info.minLineLength * 1.0s / info.pixelRate;
It is not used, so remove it. Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com> --- src/ipa/rkisp1/ipa_context.cpp | 3 --- src/ipa/rkisp1/ipa_context.h | 1 - src/ipa/rkisp1/rkisp1.cpp | 2 -- 3 files changed, 6 deletions(-)