[libcamera-devel,3/6] utils: libtuning: lsc: raspberry: Add per-image debug plotting
diff mbox series

Message ID 20221124113849.2193579-4-paul.elder@ideasonboard.com
State New
Headers show
Series
  • utils: tuning: Add per-module debugging
Related show

Commit Message

Paul Elder Nov. 24, 2022, 11:38 a.m. UTC 
Add debug plotting the LSC table for each image to the Raspberry Pi ALSC
module.

Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>
---
 utils/tuning/libtuning/modules/lsc/raspberrypi.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Dan Scally May 4, 2024, 9:16 p.m. UTC | #1 
Hi Paul

On 24/11/2022 11:38, Paul Elder wrote:
> Add debug plotting the LSC table for each image to the Raspberry Pi ALSC
> module.
>
> Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>
Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>
> ---
>   utils/tuning/libtuning/modules/lsc/raspberrypi.py | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/utils/tuning/libtuning/modules/lsc/raspberrypi.py b/utils/tuning/libtuning/modules/lsc/raspberrypi.py
> index 58f5000d..a0298348 100644
> --- a/utils/tuning/libtuning/modules/lsc/raspberrypi.py
> +++ b/utils/tuning/libtuning/modules/lsc/raspberrypi.py
> @@ -74,7 +74,8 @@ class ALSCRaspberryPi(LSC):
>           cr, _ = self._lsc_single_channel(image.channels[lt.Color.R], image, g)
>           cb, _ = self._lsc_single_channel(image.channels[lt.Color.B], image, g)
>   
> -        # \todo implement debug
> +        if self.debug:
> +            self._plot_single_lsc(image, cr, cb, cg)
>   
>           return image.color, cr.flatten(), cb.flatten(), cg.flatten()
>

Patch
diff mbox series 

diff --git a/utils/tuning/libtuning/modules/lsc/raspberrypi.py b/utils/tuning/libtuning/modules/lsc/raspberrypi.py
index 58f5000d..a0298348 100644
--- a/utils/tuning/libtuning/modules/lsc/raspberrypi.py
+++ b/utils/tuning/libtuning/modules/lsc/raspberrypi.py
@@ -74,7 +74,8 @@  class ALSCRaspberryPi(LSC):
         cr, _ = self._lsc_single_channel(image.channels[lt.Color.R], image, g)
         cb, _ = self._lsc_single_channel(image.channels[lt.Color.B], image, g)
 
-        # \todo implement debug
+        if self.debug:
+            self._plot_single_lsc(image, cr, cb, cg)
 
         return image.color, cr.flatten(), cb.flatten(), cg.flatten()