[libcamera-devel,4/6] utils: libtuning: lsc: rkisp1: Add per-image debug plotting
diff mbox series

Message ID 20221124113849.2193579-5-paul.elder@ideasonboard.com
State New
Headers show
Series
  • utils: tuning: Add per-module debugging
Related show

Commit Message

Paul Elder Nov. 24, 2022, 11:38 a.m. UTC 
Add debug plotting the LSC table for each image to the RkISP1 LSC
module.

Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>
---
 utils/tuning/libtuning/modules/lsc/rkisp1.py | 3 +++
 1 file changed, 3 insertions(+)

Comments

Dan Scally May 4, 2024, 9:16 p.m. UTC | #1 
Hi Paul

On 24/11/2022 11:38, Paul Elder wrote:
> Add debug plotting the LSC table for each image to the RkISP1 LSC
> module.
>
> Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>
> ---

Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>
>   utils/tuning/libtuning/modules/lsc/rkisp1.py | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/utils/tuning/libtuning/modules/lsc/rkisp1.py b/utils/tuning/libtuning/modules/lsc/rkisp1.py
> index 5701ae0a..c3fdcc4f 100644
> --- a/utils/tuning/libtuning/modules/lsc/rkisp1.py
> +++ b/utils/tuning/libtuning/modules/lsc/rkisp1.py
> @@ -41,6 +41,9 @@ class LSCRkISP1(LSC):
>           cr, _ = self._lsc_single_channel(image.channels[lt.Color.R], image, gr)
>           cb, _ = self._lsc_single_channel(image.channels[lt.Color.B], image, gb)
>   
> +        if self.debug:
> +            self._plot_single_lsc(image, cr, cb, cgr, cgb)
> +
>           return image.color, cr.flatten(), cb.flatten(), cgr.flatten(), cgb.flatten()
>   
>       # @return List of dictionaries of color temperature, red table, red's green

Patch
diff mbox series 

diff --git a/utils/tuning/libtuning/modules/lsc/rkisp1.py b/utils/tuning/libtuning/modules/lsc/rkisp1.py
index 5701ae0a..c3fdcc4f 100644
--- a/utils/tuning/libtuning/modules/lsc/rkisp1.py
+++ b/utils/tuning/libtuning/modules/lsc/rkisp1.py
@@ -41,6 +41,9 @@  class LSCRkISP1(LSC):
         cr, _ = self._lsc_single_channel(image.channels[lt.Color.R], image, gr)
         cb, _ = self._lsc_single_channel(image.channels[lt.Color.B], image, gb)
 
+        if self.debug:
+            self._plot_single_lsc(image, cr, cb, cgr, cgb)
+
         return image.color, cr.flatten(), cb.flatten(), cgr.flatten(), cgb.flatten()
 
     # @return List of dictionaries of color temperature, red table, red's green