[libcamera-devel,v2,3/3] libcamera: pipeline: remove unused assignment
diff mbox series

Message ID 20220816183826.102989-3-Rauch.Christian@gmx.de
State Accepted
Headers show
Series
  • [libcamera-devel,v2,1/3] libcamera: remove unused headers
Related show

Commit Message

Christian Rauch Aug. 16, 2022, 6:38 p.m. UTC 
The variable 'ret' is assigned but not read until after the next assignment.

Signed-off-by: Christian Rauch <Rauch.Christian@gmx.de>
---
 src/libcamera/pipeline/rkisp1/rkisp1.cpp | 1 -
 1 file changed, 1 deletion(-)

--
2.34.1

Comments

Laurent Pinchart Aug. 16, 2022, 7:27 p.m. UTC | #1 
Hi Christian,

Thank you for the patch.

On Tue, Aug 16, 2022 at 08:38:26PM +0200, Christian Rauch via libcamera-devel wrote:
> The variable 'ret' is assigned but not read until after the next assignment.
> 
> Signed-off-by: Christian Rauch <Rauch.Christian@gmx.de>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  src/libcamera/pipeline/rkisp1/rkisp1.cpp | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> index 93287332..03bbe6b4 100644
> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> @@ -688,7 +688,6 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)
>  		/* \todo Turn this into a hard failure. */
>  		LOG(RkISP1, Warning) << "Camera sensor information not available";
>  		sensorInfo = {};
> -		ret = 0;
>  	}
> 
>  	std::map<uint32_t, ControlInfoMap> entityControls;

Patch
diff mbox series 

diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
index 93287332..03bbe6b4 100644
--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp
+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
@@ -688,7 +688,6 @@  int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)
 		/* \todo Turn this into a hard failure. */
 		LOG(RkISP1, Warning) << "Camera sensor information not available";
 		sensorInfo = {};
-		ret = 0;
 	}

 	std::map<uint32_t, ControlInfoMap> entityControls;