From patchwork Tue Aug 16 18:38:26 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Rauch X-Patchwork-Id: 17140 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id DB9E2BE173 for ; Tue, 16 Aug 2022 18:38:35 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 2BFCB61FC3; Tue, 16 Aug 2022 20:38:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1660675115; bh=z98DY/0QKSCUgFXO+yHBw1c1rzBHI6R5i/T01he88wQ=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=dYOaREB2JdJwfMUN4PBKZy5LYk9eJkvGG4umR4jRwkwooPrmywUuF/TC57CWSodfP UnP78C90eb6EZVDI1czmHmrmzIyTUkGluDAQY0RRmiqEsdQr6B4x6cyngazyE1I6FY kDbH1nCvfGLGP2HE4DNv6xrJgX+kbbovSG3lc5ipx4neX2KE5AstrIYl8ou8Y9rcZ9 qnWHfBmB7tvHoLQZb7UvpbrOqtIOwrVazfr7GqGcbqm7sttVvlGENI+KGwvEPnAiW1 qFfPTQdG/M6B+AiEyLoCxvi1ZDKRCZ1MAws2mQCfIlI4KZEfKiJyHPE9gaCQwF+1we S176GY4lsQbHw== Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 085D861FC0 for ; Tue, 16 Aug 2022 20:38:32 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=gmx.net header.i=@gmx.net header.b="TmsfS/cN"; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1660675110; bh=z98DY/0QKSCUgFXO+yHBw1c1rzBHI6R5i/T01he88wQ=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To:References; b=TmsfS/cNbt/gz8L/UgPSz+bYN8RUQRCkBfHgAK6S3p0ht292GB5UhOPwfvrx2XuKU N4f2M611n4sPYtY2nGZcu6w4/OCJ0hDL571TJbQb5bzg6m8vYJWSF/00yb/xS4WgIm d1vS3mlOdpS0Oc5aPG1ZNP010BsNGzABnzPdDhtY= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from voyager ([88.152.184.103]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MwfWU-1nPtnT3Tpa-00yBGU; Tue, 16 Aug 2022 20:38:29 +0200 To: libcamera-devel@lists.libcamera.org Date: Tue, 16 Aug 2022 20:38:26 +0200 Message-Id: <20220816183826.102989-3-Rauch.Christian@gmx.de> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220816183826.102989-1-Rauch.Christian@gmx.de> References: <20220816183826.102989-1-Rauch.Christian@gmx.de> MIME-Version: 1.0 X-Provags-ID: V03:K1:cuctcFPU81/qwZwFY9DqBRKI1h4BE83J424cEMylq7lCxLeDpYZ E1GQNkDsHshNVLmqBu04tkQKrDwbfFa4hdJqrF5OJV7TKSLLPbAnIVc2Xav5/B87nFx22Ko ak88aQcgEZci/4Py/HuoG9y9zpLNSItyifTHPfZJnSzuFkmca2X6JnojdNz4nVyljVE71cS VeJWPXZMsKufXKuplH6KA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:LxqZKtQb+3c=:SBR4r/EoukZt2J3CHe3jxm 7u6pXMsAp0A/4cDEs8CsdQWVERfICcKX6RrBy3IErzLD5Dq8Z7WEXhGaBjp5dV0W/e4l2lHhr CUwy7mc3ldnthCZ+GiW1mG2OzamxjJvr/mtALmUKYCwE89XiIymDpypyV0Zl2fEfFOcnHR5qH iuVwWhRunGiE6xK68vi4zdGrebzD0w+4ySFZ7+5t6PiF0U5Fm91WEqvtACi5svOKk7UXQmY6R uP1gIN6P5BNT93+NhUakBLpO7VLS7HPBZxpM7HvsVigfP6GBMomszyO6lQuqFr/F/W3yY3QmO 9STT/lz0tQpywn0twHpPxb8b9sfOiKOQLSlesFCklwpnWjjAIPieS+DWIirSGFFNpSh1xUM1O SmTswai5BetmYXF375bv2AuAcdd12B58bZSg7/boRLakXo70CxaT16l5XVesK40STnsoiABi1 ZRIeHxSzKGHeaI3KxMWy+S0Gg2oiNFbE8FO+TGqnarRkAUAfSamBv/vRJRJ/R9CWzup4N83Zm xhXlXStow1sZNvJ6G+lalp+tC2PxtlyD4CX7lFYiski/wG47u4hbqTCHZznX/A+nHb40/vdOp 2tkBBsNj0P/EdzBNugUO5HhQ4GuaW2ecTK71/UHwZ2vjXYsQUazirRSM7hMOS+lo4Cif5SU4f VGonA8m+4CrzdoMjHaldWvgkwNKsDx9mUHTgqcwWj8eH4eniMswd6f44tDd7QXvJkTZFVSOTC VeV4ygXawtyiJsDLcxcUOmqhif5blL2HsNyXwWJwVT8+8TktvmVXcM/YqKa2UNKjB+n8vgfY3 wHYYVGhC0mdpw153on3Dmp29UugRCOBwK6WvMqUSDrm8j6gkYg/xAoNcZ36WcDa5GJUQV51Q1 8dVZLOV6KonxxT9eYWpJ/wZ1QCwK1YT2xbpaG7bRJYAMj870WOIz3uI1L8rDusEX6tj7I4lC5 gygL6SA7W5Kk8uDPDvrAYrHKqc7oMFF998K0d7XLb+JtNowsdxAmK/tgrlgKL2/cs6Xzz6R+C HGKEJ9W8645Vwe+rbtt+sCsqVV+67QY5v4b29kMBbb6E5ciK2tyPqqgoL6dhh9FWSRQTDBW1I Ys6RPcecpkvZ1+p6uXJqg9ikzhLlxiRsgIMGT55lUEeLU88km+TrEw7uw== Subject: [libcamera-devel] [PATCH v2 3/3] libcamera: pipeline: remove unused assignment X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Christian Rauch via libcamera-devel From: Christian Rauch Reply-To: Christian Rauch Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The variable 'ret' is assigned but not read until after the next assignment. Signed-off-by: Christian Rauch Reviewed-by: Laurent Pinchart --- src/libcamera/pipeline/rkisp1/rkisp1.cpp | 1 - 1 file changed, 1 deletion(-) -- 2.34.1 diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp index 93287332..03bbe6b4 100644 --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp @@ -688,7 +688,6 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c) /* \todo Turn this into a hard failure. */ LOG(RkISP1, Warning) << "Camera sensor information not available"; sensorInfo = {}; - ret = 0; } std::map entityControls;