[libcamera-devel,v2,1/3] libcamera: remove unused headers
diff mbox series

Message ID 20220816183826.102989-1-Rauch.Christian@gmx.de
State Accepted
Headers show
Series
  • [libcamera-devel,v2,1/3] libcamera: remove unused headers
Related show

Commit Message

Christian Rauch Aug. 16, 2022, 6:38 p.m. UTC
These headers are not used as reported by clangd.

Signed-off-by: Christian Rauch <Rauch.Christian@gmx.de>
---
 src/ipa/raspberrypi/raspberrypi.cpp             | 1 -
 test/serialization/ipa_data_serializer_test.cpp | 4 ----
 2 files changed, 5 deletions(-)

--
2.34.1

Comments

Laurent Pinchart Aug. 16, 2022, 7:25 p.m. UTC | #1
Hi Christian,

Thank you for the patch.

On Tue, Aug 16, 2022 at 08:38:24PM +0200, Christian Rauch via libcamera-devel wrote:
> These headers are not used as reported by clangd.
> 
> Signed-off-by: Christian Rauch <Rauch.Christian@gmx.de>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  src/ipa/raspberrypi/raspberrypi.cpp             | 1 -
>  test/serialization/ipa_data_serializer_test.cpp | 4 ----
>  2 files changed, 5 deletions(-)
> 
> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp
> index 69c73f8c..8d731435 100644
> --- a/src/ipa/raspberrypi/raspberrypi.cpp
> +++ b/src/ipa/raspberrypi/raspberrypi.cpp
> @@ -49,7 +49,6 @@
>  #include "geq_status.h"
>  #include "lux_status.h"
>  #include "metadata.h"
> -#include "noise_status.h"
>  #include "sharpen_algorithm.h"
>  #include "sharpen_status.h"
> 
> diff --git a/test/serialization/ipa_data_serializer_test.cpp b/test/serialization/ipa_data_serializer_test.cpp
> index d2050a86..377ecdb0 100644
> --- a/test/serialization/ipa_data_serializer_test.cpp
> +++ b/test/serialization/ipa_data_serializer_test.cpp
> @@ -20,11 +20,7 @@
>  #include <libcamera/base/thread.h>
>  #include <libcamera/base/timer.h>
> 
> -#include "libcamera/internal/device_enumerator.h"
>  #include "libcamera/internal/ipa_data_serializer.h"
> -#include "libcamera/internal/ipa_manager.h"
> -#include "libcamera/internal/ipa_module.h"
> -#include "libcamera/internal/pipeline_handler.h"
> 
>  #include "serialization_test.h"
>  #include "test.h"

Patch
diff mbox series

diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp
index 69c73f8c..8d731435 100644
--- a/src/ipa/raspberrypi/raspberrypi.cpp
+++ b/src/ipa/raspberrypi/raspberrypi.cpp
@@ -49,7 +49,6 @@ 
 #include "geq_status.h"
 #include "lux_status.h"
 #include "metadata.h"
-#include "noise_status.h"
 #include "sharpen_algorithm.h"
 #include "sharpen_status.h"

diff --git a/test/serialization/ipa_data_serializer_test.cpp b/test/serialization/ipa_data_serializer_test.cpp
index d2050a86..377ecdb0 100644
--- a/test/serialization/ipa_data_serializer_test.cpp
+++ b/test/serialization/ipa_data_serializer_test.cpp
@@ -20,11 +20,7 @@ 
 #include <libcamera/base/thread.h>
 #include <libcamera/base/timer.h>

-#include "libcamera/internal/device_enumerator.h"
 #include "libcamera/internal/ipa_data_serializer.h"
-#include "libcamera/internal/ipa_manager.h"
-#include "libcamera/internal/ipa_module.h"
-#include "libcamera/internal/pipeline_handler.h"

 #include "serialization_test.h"
 #include "test.h"