From patchwork Tue Aug 16 18:38:24 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Rauch X-Patchwork-Id: 17139 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id A9A42C3275 for ; Tue, 16 Aug 2022 18:38:34 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 5E16461FC5; Tue, 16 Aug 2022 20:38:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1660675114; bh=FVy5ExCvOE89TsYBwbj+DTpJeVHfjamJ8HFG03KETBU=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=EEn+9AEBarnKNg2wWeRNK0zeZkjSn+Cj22dIE32Ed5LolLxv6AW1Tei1L2TBxOXHT JDVjN7EkIHla5bMDh2tiWzsQZ6VcLNFJOH58vUTZxISkYopjOGMgsw2epSBfby3dlO 8lPm2DYhBgv4/qiQm/ewTPPjOuW1HKDqvMQ9gLLp4QZi7SSKN4c/NMCsteIDdoeL0D /LDc8xAZOgllI+O9uMOo8oE6qbashf0VnaSsqIEgsij9Z4aVkjhsS9LDA/Taw9XwiH QKWYDPLgX5qWduuc2sDO1Spe0uUUzym1JSt57up+Mzdrvs4nxNI556mjLjJp779BXt 1f0WPPdP2bIFA== Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id F008661FBC for ; Tue, 16 Aug 2022 20:38:31 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=gmx.net header.i=@gmx.net header.b="fFRX8orS"; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1660675109; bh=FVy5ExCvOE89TsYBwbj+DTpJeVHfjamJ8HFG03KETBU=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date; b=fFRX8orS7f+XUnxx+T8dDcMm1isZVVcYVmf2Df2oqdC6XjnIe1kZAxIn/ux2MnXyK /mmR55GGSwcx6ITWRebOqH+ByBE9tFjmr/2KGEO9NBRO7abbvOMSPKSFMv8uSRbNtG xtj6ejbKcoimKfE7tJOPEvZOy9PJZUjKpem4si2U= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from voyager ([88.152.184.103]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MQvD5-1o2FLm2NCZ-00O127; Tue, 16 Aug 2022 20:38:29 +0200 To: libcamera-devel@lists.libcamera.org Date: Tue, 16 Aug 2022 20:38:24 +0200 Message-Id: <20220816183826.102989-1-Rauch.Christian@gmx.de> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Provags-ID: V03:K1:mTWYSCfAAenowFaW6EE8SB7jottvhx2dVGlxzblxs39X6MOLi8G sHVwjzgiuYqsfe7SdRKZ/Xg6IVlqk5Z1UVuTr9zUahSXJ0kZZr4UssFc41v9MYzJzJL8NNF TZF6UXMqh+Aj9fdPHxKsw2ayx3nSDRdXkIf/PKpJG1hPYf+K8LGer/HQPWlVwv00KEcrGFc HCszcmaj2vj9557zT0qbA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:8Lhlv2nMhJo=:94fGjz7ay6Y/qOVkdenlz/ lit1bj0CWhWodL8BOdFLfCNvsbNfbBAJhvnhafKbvGYbdsxPvcf/Hf4/Q2MIP3t31VjujNZkI x6IITsHMkX2d/WzlWBB6u4cZGvcqr73TS1Y3oys8vveZX1uTeb8VZ2T2CO7RvP4ZNbYvWEGCG oskiF7cQPEGSux4hIOip8Zn9mCLtZkNt+8NtCpDls30PpaLkC9mUe37zrU34XsDjKnfIVorox nrCbVJ1sGMc8eogwP4HM5HO0yL0CPwFW2rb01mdlnEZm8EC3BRAmHAAMGH5ih0/w+AD0pzKGV 0gnrJhbIhYkYJ0m+0cndLsTCD/ROs2t8fUohKiEGTGkLjFaNPEzD2V7LOvsgQTWPjfkGd2xrM zPS1qIduVmCD+tuJsGOE/1LdYKSVSo79MUVvH+qf8arV/qDKpXtoqNun85LvjMqwLglkPlWYj lHK3eysOX9bgNyqM2c2imuHXoNr/fB84IWavXnICHYw5fAZObW1Vuc5M+rPqyTPoTG1f63vY0 56UPY4ImUsOSFg6Z7Cd8COgFokLsSagKPTO7Jksc6T+dMCG/qVwO4VVpFmJZfGSfCscDYaCij /9p2E+S/mZKenW+RKjToRtooQjuVar2GiOokwmDC7sbrc0hnntXpBT4C7HKj0UyofHoO+rLy7 ui1hvtXmzW8/Z17TAEs1pH6pgM4DqR/CXoVRsulOpad+VeRIdeICz+00ztxUw+pAXKr4U8zRG vpm/shOkwKGm9FFgrWt2ajge4FIu3vS+fPaCxXPIiJvNRWjhzd1z7/V1oLtcWbtHjZ3bnmXrr jWhtDzpKjQe2etGMCdWLDee8sBPPovkjAYqsx/cr/FObbx59pPmjEoQIEDBIVuM5ySipb5aJ1 Crm5VRBoaN8ACYa794WrybiS5Nz9lP/AVi4TiCV9NvhriWuRmpNnScCzIkgxSx5eM2+ZEngr3 o+RI0u6V9dva80/fnhGcsoeyMurXQdUJkejKGCqH+stYrdKXrFlUNSnn/+v3bQaMTeTbXptDM bU9Nz2nRjjE9GGo7cjMExVsYS1am3wrGVi+31YfFkfVcRFWHC0l895shunHIRspie2aJAQRt6 o4elkU78Y9MXzMEb59gUdTJNBBjwEQfYWaSwaqBvnwZ3V+0FhTXtW3Hsg== Subject: [libcamera-devel] [PATCH v2 1/3] libcamera: remove unused headers X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Christian Rauch via libcamera-devel From: Christian Rauch Reply-To: Christian Rauch Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" These headers are not used as reported by clangd. Signed-off-by: Christian Rauch Reviewed-by: Laurent Pinchart --- src/ipa/raspberrypi/raspberrypi.cpp | 1 - test/serialization/ipa_data_serializer_test.cpp | 4 ---- 2 files changed, 5 deletions(-) -- 2.34.1 diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp index 69c73f8c..8d731435 100644 --- a/src/ipa/raspberrypi/raspberrypi.cpp +++ b/src/ipa/raspberrypi/raspberrypi.cpp @@ -49,7 +49,6 @@ #include "geq_status.h" #include "lux_status.h" #include "metadata.h" -#include "noise_status.h" #include "sharpen_algorithm.h" #include "sharpen_status.h" diff --git a/test/serialization/ipa_data_serializer_test.cpp b/test/serialization/ipa_data_serializer_test.cpp index d2050a86..377ecdb0 100644 --- a/test/serialization/ipa_data_serializer_test.cpp +++ b/test/serialization/ipa_data_serializer_test.cpp @@ -20,11 +20,7 @@ #include #include -#include "libcamera/internal/device_enumerator.h" #include "libcamera/internal/ipa_data_serializer.h" -#include "libcamera/internal/ipa_manager.h" -#include "libcamera/internal/ipa_module.h" -#include "libcamera/internal/pipeline_handler.h" #include "serialization_test.h" #include "test.h" From patchwork Tue Aug 16 18:38:25 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Rauch X-Patchwork-Id: 17138 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 88A13BE173 for ; Tue, 16 Aug 2022 18:38:33 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id A25B661FBC; Tue, 16 Aug 2022 20:38:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1660675112; bh=TKl/bH6hDjXvaDwaz5+NOoWJGJVITPeq61cwGw1bAlU=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=AMA79q89Bxx7PtBXz7+QB01qnCyc7cOIWKi11pbAxxjvSvBFu8vmDZam5IWIdRYEX 19Ba+FnXRuYBlUITF+umQmXN/mHM5a5p/t73BR711nDzBLqMBDJO6/bZpRvaF2kWvM XTx4dfY4bzTugdXrEK+7uJGxXX8u97odxEUyiFm7rCKDXxEN2qXmkkOXgs6oU0i9sA UZVIlYrxADU8mURaDOO94TuLsncPjP6LGa79qzpkUo4OYR/AHOfDXOyIrFCncOAyvC X1Gj8Hot0fH019HBcKbkwQbDyJ1+Hrj6pKurZxJBxf7AMVzNkRf27TH2VxEDaYwnef Q8FhL0YGu86wQ== Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 4BEA561FA9 for ; Tue, 16 Aug 2022 20:38:30 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=gmx.net header.i=@gmx.net header.b="MBJFn9iI"; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1660675109; bh=TKl/bH6hDjXvaDwaz5+NOoWJGJVITPeq61cwGw1bAlU=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To:References; b=MBJFn9iIS3jrFdz2004J9Y49TSi5vuzMydPrsVjUb/nEyTCkV8+G/kJFnMytwt6DJ 963S4tYAHAgIHBIG/H30D1xHKgeYRaKs9DzOCakrYtNQ0RiainMs51nfVF7AqP2nWD +BR70RMOGdldecJXoaRbPBSc8KLZ73yVWdIbV8x8= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from voyager ([88.152.184.103]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MmULx-1nfa1E2uqv-00iRXd; Tue, 16 Aug 2022 20:38:29 +0200 To: libcamera-devel@lists.libcamera.org Date: Tue, 16 Aug 2022 20:38:25 +0200 Message-Id: <20220816183826.102989-2-Rauch.Christian@gmx.de> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220816183826.102989-1-Rauch.Christian@gmx.de> References: <20220816183826.102989-1-Rauch.Christian@gmx.de> MIME-Version: 1.0 X-Provags-ID: V03:K1:UAMPlQkLVOQThs0PcChzpRQDYlJqy0SYVSqaYAjYTs776ipCNbJ /1RdM33LA75h4ou0wS1J9dU+qPBmZ5ALWqiQkIlekuOQNAEont+9EODngJ7ED11p8yVgmex nNEp3h18dJa5StoA+QFXAb4EFZ5gziBDNvvNl9ag0lwnVHnuVWEixtvG2lMK94n9cKbtbC6 F6d3dTTwpRWHFjs3mg+TA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:h71FcNWhDjs=:HXxCVR0nEeph6fKsGr3apH 6kE6yRbbltxz3RUxw2pjA0xZDMaoMmB4e/gNDPDdT3l7DvcIAg7lwyB/hTq/oyw/L+8GuWL58 7w0wtJ5pOaT3c5E+OGULtrZ8KvAtmR4Vrecyd8LLP8EBW5HjlzWDDrPexG+vk+w1nvaJ1NRkI Co2HmkhLghRN7wmJY+qiTr6HGHFdSNjWcwQtulyY145H2UQ+Ipq1ZFexV0HGemgzkNuQpN7Vz UFbfS3x3Vq9vsFWPQmN8pcnRNwwTcfgi2tBQowMHzwVPeTCblDU2dvlyvoRzCWq5nuStAB6kV DVXqJyxa8LJvCjSw+6d1C/KRPrWlNWdzVAeDZZDfmvPJOgXuaFaK8JKLs6lgi+6hCs3tR7uW7 sFnksdb7/n+W6i71ME3rtMU6bJED9WyXIlmL7TE9aSrZYkBbOG82PRFTtInYLpQK1KEM0vzZ2 PzH3PwiXkqU3txELbj+c93dg8asdnLtgUVGfsWSHw3KVO28v8A7954orFEA3IWXscQKMcUUK8 mOwAvp4OaKebruqWsiw+78XQOMYCvbx5/mXMuYB9BdblQ9+3ucD7XnclVmpzw/E0eg+UzKaLT cAUGzMpq0YLWSxPZJFPEdAyGV5VCXHX3n5kdKrU/mT5DEKQZqCEPAEweUwQZcKm+2uYh2HRUg DnOQsO5ISukisYRyLOesN3QcqNZ+makugHkuYxC+voK9vYVbGUx2/eyv4sRSmJYYw8UZibXNT HJ8c0UQXoKqjuA8/5+au4ZKsuHbSVO7a5Mf6S6hTM5MiLCDF3WFY/0thUfepi+sOLYd0oXv9G cuNIxdfO07AwxRlRGayQ8rO0PTEqe242M4qgBthHq49rzNvdyEX+SvtrmkWfrsuRWRqQqenCg NKJ3TA5adzCYXpbSw8XfXb9j5zDr5mZUWB+6xEMBNPHsCXHi03go+T4L3g02ZgBYlf4vsSbwz 35gAF9eL+aXMrx7s3UdGrAgHOvueS5YYpb/+oaVCgWuWKLxYr14H8PTbnJJrR0BHRnwVZKwFz chEWq5YQWqxnzpWCL2DvAUCLV/mi36EKwJAzz/SPUU/UXcBoDVQV5Fm1EjZEMxQC4ZP5FBGlq ts/i25g61DyKhpXKfHCipPea3DQy40BGWwdQ4QWq2q/iEUMOKvMwYymOA== Subject: [libcamera-devel] [PATCH v2 2/3] libcamera: use const reference for range loops X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Christian Rauch via libcamera-devel From: Christian Rauch Reply-To: Christian Rauch Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" A const reference prevents unnecessary copies of the loop elements. Signed-off-by: Christian Rauch Reviewed-by: Laurent Pinchart --- src/libcamera/camera_manager.cpp | 2 +- src/libcamera/device_enumerator.cpp | 2 +- src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 6 +----- src/libcamera/pipeline/vimc/vimc.cpp | 2 +- src/libcamera/pipeline_handler.cpp | 2 +- 5 files changed, 5 insertions(+), 9 deletions(-) -- 2.34.1 diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp index 70d73822..7ff4bc6f 100644 --- a/src/libcamera/camera_manager.cpp +++ b/src/libcamera/camera_manager.cpp @@ -189,7 +189,7 @@ void CameraManager::Private::addCamera(std::shared_ptr camera, { MutexLocker locker(mutex_); - for (std::shared_ptr c : cameras_) { + for (const std::shared_ptr &c : cameras_) { if (c->id() == camera->id()) { LOG(Camera, Fatal) << "Trying to register a camera with a duplicated ID '" diff --git a/src/libcamera/device_enumerator.cpp b/src/libcamera/device_enumerator.cpp index d1258050..f2e055de 100644 --- a/src/libcamera/device_enumerator.cpp +++ b/src/libcamera/device_enumerator.cpp @@ -161,7 +161,7 @@ std::unique_ptr DeviceEnumerator::create() DeviceEnumerator::~DeviceEnumerator() { - for (std::shared_ptr media : devices_) { + for (const std::shared_ptr &media : devices_) { if (media->busy()) LOG(DeviceEnumerator, Error) << "Removing media device " << media->deviceNode() diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp index fbe02cdc..9cbf126a 100644 --- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp +++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp @@ -340,12 +340,8 @@ int PipelineHandlerUVC::processControls(UVCCameraData *data, Request *request) { ControlList controls(data->video_->controls()); - for (auto it : request->controls()) { - unsigned int id = it.first; - ControlValue &value = it.second; - + for (const auto &[id, value] : request->controls()) processControl(&controls, id, value); - } for (const auto &ctrl : controls) LOG(UVC, Debug) diff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp index 153cf849..d2f2e460 100644 --- a/src/libcamera/pipeline/vimc/vimc.cpp +++ b/src/libcamera/pipeline/vimc/vimc.cpp @@ -378,7 +378,7 @@ int PipelineHandlerVimc::processControls(VimcCameraData *data, Request *request) { ControlList controls(data->sensor_->controls()); - for (auto it : request->controls()) { + for (const auto &it : request->controls()) { unsigned int id = it.first; unsigned int offset; uint32_t cid; diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp index 7d2d00ef..e5cb751c 100644 --- a/src/libcamera/pipeline_handler.cpp +++ b/src/libcamera/pipeline_handler.cpp @@ -616,7 +616,7 @@ void PipelineHandler::disconnect() */ std::vector> cameras{ std::move(cameras_) }; - for (std::weak_ptr ptr : cameras) { + for (const std::weak_ptr &ptr : cameras) { std::shared_ptr camera = ptr.lock(); if (!camera) continue; From patchwork Tue Aug 16 18:38:26 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Rauch X-Patchwork-Id: 17140 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id DB9E2BE173 for ; Tue, 16 Aug 2022 18:38:35 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 2BFCB61FC3; Tue, 16 Aug 2022 20:38:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1660675115; bh=z98DY/0QKSCUgFXO+yHBw1c1rzBHI6R5i/T01he88wQ=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=dYOaREB2JdJwfMUN4PBKZy5LYk9eJkvGG4umR4jRwkwooPrmywUuF/TC57CWSodfP UnP78C90eb6EZVDI1czmHmrmzIyTUkGluDAQY0RRmiqEsdQr6B4x6cyngazyE1I6FY kDbH1nCvfGLGP2HE4DNv6xrJgX+kbbovSG3lc5ipx4neX2KE5AstrIYl8ou8Y9rcZ9 qnWHfBmB7tvHoLQZb7UvpbrOqtIOwrVazfr7GqGcbqm7sttVvlGENI+KGwvEPnAiW1 qFfPTQdG/M6B+AiEyLoCxvi1ZDKRCZ1MAws2mQCfIlI4KZEfKiJyHPE9gaCQwF+1we S176GY4lsQbHw== Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 085D861FC0 for ; Tue, 16 Aug 2022 20:38:32 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=gmx.net header.i=@gmx.net header.b="TmsfS/cN"; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1660675110; bh=z98DY/0QKSCUgFXO+yHBw1c1rzBHI6R5i/T01he88wQ=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To:References; b=TmsfS/cNbt/gz8L/UgPSz+bYN8RUQRCkBfHgAK6S3p0ht292GB5UhOPwfvrx2XuKU N4f2M611n4sPYtY2nGZcu6w4/OCJ0hDL571TJbQb5bzg6m8vYJWSF/00yb/xS4WgIm d1vS3mlOdpS0Oc5aPG1ZNP010BsNGzABnzPdDhtY= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from voyager ([88.152.184.103]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MwfWU-1nPtnT3Tpa-00yBGU; Tue, 16 Aug 2022 20:38:29 +0200 To: libcamera-devel@lists.libcamera.org Date: Tue, 16 Aug 2022 20:38:26 +0200 Message-Id: <20220816183826.102989-3-Rauch.Christian@gmx.de> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220816183826.102989-1-Rauch.Christian@gmx.de> References: <20220816183826.102989-1-Rauch.Christian@gmx.de> MIME-Version: 1.0 X-Provags-ID: V03:K1:cuctcFPU81/qwZwFY9DqBRKI1h4BE83J424cEMylq7lCxLeDpYZ E1GQNkDsHshNVLmqBu04tkQKrDwbfFa4hdJqrF5OJV7TKSLLPbAnIVc2Xav5/B87nFx22Ko ak88aQcgEZci/4Py/HuoG9y9zpLNSItyifTHPfZJnSzuFkmca2X6JnojdNz4nVyljVE71cS VeJWPXZMsKufXKuplH6KA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:LxqZKtQb+3c=:SBR4r/EoukZt2J3CHe3jxm 7u6pXMsAp0A/4cDEs8CsdQWVERfICcKX6RrBy3IErzLD5Dq8Z7WEXhGaBjp5dV0W/e4l2lHhr CUwy7mc3ldnthCZ+GiW1mG2OzamxjJvr/mtALmUKYCwE89XiIymDpypyV0Zl2fEfFOcnHR5qH iuVwWhRunGiE6xK68vi4zdGrebzD0w+4ySFZ7+5t6PiF0U5Fm91WEqvtACi5svOKk7UXQmY6R uP1gIN6P5BNT93+NhUakBLpO7VLS7HPBZxpM7HvsVigfP6GBMomszyO6lQuqFr/F/W3yY3QmO 9STT/lz0tQpywn0twHpPxb8b9sfOiKOQLSlesFCklwpnWjjAIPieS+DWIirSGFFNpSh1xUM1O SmTswai5BetmYXF375bv2AuAcdd12B58bZSg7/boRLakXo70CxaT16l5XVesK40STnsoiABi1 ZRIeHxSzKGHeaI3KxMWy+S0Gg2oiNFbE8FO+TGqnarRkAUAfSamBv/vRJRJ/R9CWzup4N83Zm xhXlXStow1sZNvJ6G+lalp+tC2PxtlyD4CX7lFYiski/wG47u4hbqTCHZznX/A+nHb40/vdOp 2tkBBsNj0P/EdzBNugUO5HhQ4GuaW2ecTK71/UHwZ2vjXYsQUazirRSM7hMOS+lo4Cif5SU4f VGonA8m+4CrzdoMjHaldWvgkwNKsDx9mUHTgqcwWj8eH4eniMswd6f44tDd7QXvJkTZFVSOTC VeV4ygXawtyiJsDLcxcUOmqhif5blL2HsNyXwWJwVT8+8TktvmVXcM/YqKa2UNKjB+n8vgfY3 wHYYVGhC0mdpw153on3Dmp29UugRCOBwK6WvMqUSDrm8j6gkYg/xAoNcZ36WcDa5GJUQV51Q1 8dVZLOV6KonxxT9eYWpJ/wZ1QCwK1YT2xbpaG7bRJYAMj870WOIz3uI1L8rDusEX6tj7I4lC5 gygL6SA7W5Kk8uDPDvrAYrHKqc7oMFF998K0d7XLb+JtNowsdxAmK/tgrlgKL2/cs6Xzz6R+C HGKEJ9W8645Vwe+rbtt+sCsqVV+67QY5v4b29kMBbb6E5ciK2tyPqqgoL6dhh9FWSRQTDBW1I Ys6RPcecpkvZ1+p6uXJqg9ikzhLlxiRsgIMGT55lUEeLU88km+TrEw7uw== Subject: [libcamera-devel] [PATCH v2 3/3] libcamera: pipeline: remove unused assignment X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Christian Rauch via libcamera-devel From: Christian Rauch Reply-To: Christian Rauch Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The variable 'ret' is assigned but not read until after the next assignment. Signed-off-by: Christian Rauch Reviewed-by: Laurent Pinchart --- src/libcamera/pipeline/rkisp1/rkisp1.cpp | 1 - 1 file changed, 1 deletion(-) -- 2.34.1 diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp index 93287332..03bbe6b4 100644 --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp @@ -688,7 +688,6 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c) /* \todo Turn this into a hard failure. */ LOG(RkISP1, Warning) << "Camera sensor information not available"; sensorInfo = {}; - ret = 0; } std::map entityControls;