[RFC,v4,08/23] ipa: libipa: agc: Initialize "Maximize" mode when none given
diff mbox series

Message ID 20261026132045.269007-9-barnabas.pocze@ideasonboard.com
State Superseded
Headers show
Series
  • ipa: libipa: agc: Take exposure margin into account
Related show

Commit Message

Barnabás Pőcze Oct. 26, 2026, 1:20 p.m. UTC
If the tuning file containts no exposure modes, then automatically initialize
a "Maximize" mode instead of "Normal", because that better describes the actual
behaviour.

Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
---
 src/ipa/libipa/agc.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jacopo Mondi Oct. 27, 2026, 8:22 a.m. UTC | #1
Hi Barnabás

On Mon, Oct 26, 2026 at 02:20:30PM +0100, Barnabás Pőcze wrote:
> If the tuning file containts no exposure modes, then automatically initialize
> a "Maximize" mode instead of "Normal", because that better describes the actual
> behaviour.

true that

>
> Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>

Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>

> ---
>  src/ipa/libipa/agc.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/ipa/libipa/agc.cpp b/src/ipa/libipa/agc.cpp
> index a27813b8bf..b899f7c643 100644
> --- a/src/ipa/libipa/agc.cpp
> +++ b/src/ipa/libipa/agc.cpp
> @@ -448,7 +448,7 @@ void fillMissing(AgcMeanLuminance::Configuration &config)
>  	 */
>  	if (config.exposureModeHelpers.empty())
>  		config.exposureModeHelpers.try_emplace(
> -			controls::ExposureNormal,
> +			controls::ExposureMaximize,
>  			std::vector<ExposureModeHelper::Stage>{});
>
>  	/*
> --
> 2.56.0
>

Patch
diff mbox series

diff --git a/src/ipa/libipa/agc.cpp b/src/ipa/libipa/agc.cpp
index a27813b8bf..b899f7c643 100644
--- a/src/ipa/libipa/agc.cpp
+++ b/src/ipa/libipa/agc.cpp
@@ -448,7 +448,7 @@  void fillMissing(AgcMeanLuminance::Configuration &config)
 	 */
 	if (config.exposureModeHelpers.empty())
 		config.exposureModeHelpers.try_emplace(
-			controls::ExposureNormal,
+			controls::ExposureMaximize,
 			std::vector<ExposureModeHelper::Stage>{});
 
 	/*