[RFC,v4,03/23] ipa: libipa: exposure_mode_helper: Remove defaulted destructor
diff mbox series

Message ID 20261026132045.269007-4-barnabas.pocze@ideasonboard.com
State Superseded
Headers show
Series
  • ipa: libipa: agc: Take exposure margin into account
Related show

Commit Message

Barnabás Pőcze Oct. 26, 2026, 1:20 p.m. UTC
It does not have any effect, the destructor will be defaulted
implicitly, so remove it.

Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
---
 src/ipa/libipa/exposure_mode_helper.h | 1 -
 1 file changed, 1 deletion(-)

Comments

Kieran Bingham Oct. 26, 2026, 7:38 p.m. UTC | #1
Quoting Barnabás Pőcze (2026-10-26 13:20:25)
> It does not have any effect, the destructor will be defaulted
> implicitly, so remove it.
> 
> Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
> Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> ---
>  src/ipa/libipa/exposure_mode_helper.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/src/ipa/libipa/exposure_mode_helper.h b/src/ipa/libipa/exposure_mode_helper.h
> index a56e19061b..d0d468a6a2 100644
> --- a/src/ipa/libipa/exposure_mode_helper.h
> +++ b/src/ipa/libipa/exposure_mode_helper.h
> @@ -23,7 +23,6 @@ class ExposureModeHelper
>  {
>  public:
>         ExposureModeHelper(std::span<std::pair<utils::Duration, double>> stages);
> -       ~ExposureModeHelper() = default;
>  
>         void configure(utils::Duration lineLength, const CameraSensorHelper *sensorHelper);
>         void setLimits(utils::Duration minExposureTime, utils::Duration maxExposureTime,
> -- 
> 2.56.0
>

Patch
diff mbox series

diff --git a/src/ipa/libipa/exposure_mode_helper.h b/src/ipa/libipa/exposure_mode_helper.h
index a56e19061b..d0d468a6a2 100644
--- a/src/ipa/libipa/exposure_mode_helper.h
+++ b/src/ipa/libipa/exposure_mode_helper.h
@@ -23,7 +23,6 @@  class ExposureModeHelper
 {
 public:
 	ExposureModeHelper(std::span<std::pair<utils::Duration, double>> stages);
-	~ExposureModeHelper() = default;
 
 	void configure(utils::Duration lineLength, const CameraSensorHelper *sensorHelper);
 	void setLimits(utils::Duration minExposureTime, utils::Duration maxExposureTime,