[RFC,v4,02/23] ipa: libipa: agc: Change `AgcMSV` exposure mode
diff mbox series

Message ID 20261026132045.269007-3-barnabas.pocze@ideasonboard.com
State New
Headers show
Series
  • ipa: libipa: agc: Take exposure margin into account
Related show

Commit Message

Barnabás Pőcze Oct. 26, 2026, 1:20 p.m. UTC
The `AgcMSV` implementation does not really support exposure modes like
`AgcMeanLuminance`. Instead it works by maximizing exposure time, then
analogue gain. This behaviour is best described by the newly introduced
"Maximize" exposure mode, so report that.

Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
---
 src/ipa/libipa/agc.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Patch
diff mbox series

diff --git a/src/ipa/libipa/agc.cpp b/src/ipa/libipa/agc.cpp
index 51b05e3c2a..e23cb13cb7 100644
--- a/src/ipa/libipa/agc.cpp
+++ b/src/ipa/libipa/agc.cpp
@@ -487,9 +487,9 @@  int AgcAlgorithm::configure(agc::Session &session, agc::ActiveState &state,
 
 	std::visit(utils::overloaded{
 		[&](AgcMSV &) {
-			/* No constraint/exposure mode support. */
+			/* No constraint mode support. */
 			state.constraintMode = controls::AeConstraintModeEnum::ConstraintNormal;
-			state.exposureMode = controls::AeExposureModeEnum::ExposureNormal;
+			state.exposureMode = controls::AeExposureModeEnum::ExposureMaximize;
 
 			state.automatic.yTarget = 0; /* Not supported. */