[RFC,v4,13/23] ipa: libipa: agc: Report `FrameDurationLimits`
diff mbox series

Message ID 20261026132045.269007-14-barnabas.pocze@ideasonboard.com
State Superseded
Headers show
Series
  • ipa: libipa: agc: Take exposure margin into account
Related show

Commit Message

Barnabás Pőcze Oct. 26, 2026, 1:20 p.m. UTC
`FrameDurationLimits` can be reported in metadata, to signal the exact
limits that were used when processing the frame. This was missing from
the agc algorithm, so add it.

Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
---
 src/ipa/libipa/agc.cpp | 3 +++
 1 file changed, 3 insertions(+)

Comments

Kieran Bingham Oct. 26, 2026, 8:16 p.m. UTC | #1
Quoting Barnabás Pőcze (2026-10-26 13:20:35)
> `FrameDurationLimits` can be reported in metadata, to signal the exact
> limits that were used when processing the frame. This was missing from
> the agc algorithm, so add it.
> 
> Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
> Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>

I think this is reasonable... It's a range that's used internally, but
it is something which can be configured by the user, so it's helpful to
report the used values.

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> ---
>  src/ipa/libipa/agc.cpp | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/src/ipa/libipa/agc.cpp b/src/ipa/libipa/agc.cpp
> index 0942f26bf2..ff3d52c163 100644
> --- a/src/ipa/libipa/agc.cpp
> +++ b/src/ipa/libipa/agc.cpp
> @@ -1127,6 +1127,9 @@ void AgcAlgorithm::fillMetadata(const agc::Session &session,
>         metadata.set(controls::ExposureTime,
>                      utils::Duration(session.lineDuration * frameContext.exposure).get<std::micro>());
>         metadata.set(controls::FrameDuration, frameContext.frameDuration.get<std::micro>());
> +       metadata.set(controls::FrameDurationLimits,
> +                    { static_cast<int64_t>(frameContext.minFrameDuration.get<std::micro>()),
> +                      static_cast<int64_t>(frameContext.maxFrameDuration.get<std::micro>()) });
>         metadata.set(controls::ExposureTimeMode, frameContext.autoExposureEnabled
>                                                  ? controls::ExposureTimeModeAuto
>                                                  : controls::ExposureTimeModeManual);
> -- 
> 2.56.0
>

Patch
diff mbox series

diff --git a/src/ipa/libipa/agc.cpp b/src/ipa/libipa/agc.cpp
index 0942f26bf2..ff3d52c163 100644
--- a/src/ipa/libipa/agc.cpp
+++ b/src/ipa/libipa/agc.cpp
@@ -1127,6 +1127,9 @@  void AgcAlgorithm::fillMetadata(const agc::Session &session,
 	metadata.set(controls::ExposureTime,
 		     utils::Duration(session.lineDuration * frameContext.exposure).get<std::micro>());
 	metadata.set(controls::FrameDuration, frameContext.frameDuration.get<std::micro>());
+	metadata.set(controls::FrameDurationLimits,
+		     { static_cast<int64_t>(frameContext.minFrameDuration.get<std::micro>()),
+		       static_cast<int64_t>(frameContext.maxFrameDuration.get<std::micro>()) });
 	metadata.set(controls::ExposureTimeMode, frameContext.autoExposureEnabled
 						 ? controls::ExposureTimeModeAuto
 						 : controls::ExposureTimeModeManual);