[RFC,v4,05/23] ipa: libipa: exposure_mode_helper: Remove limit getters
diff mbox series

Message ID 20261026132045.269007-6-barnabas.pocze@ideasonboard.com
State Superseded
Headers show
Series
  • ipa: libipa: agc: Take exposure margin into account
Related show

Commit Message

Barnabás Pőcze Oct. 26, 2026, 1:20 p.m. UTC
These getters have not been used since their introduction, so remove
them for now. They can be easily restored if needed.

Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
---
 src/ipa/libipa/exposure_mode_helper.cpp | 25 -------------------------
 src/ipa/libipa/exposure_mode_helper.h   |  5 -----
 2 files changed, 30 deletions(-)

Comments

Kieran Bingham Oct. 26, 2026, 7:48 p.m. UTC | #1
Quoting Barnabás Pőcze (2026-10-26 13:20:27)
> These getters have not been used since their introduction, so remove
> them for now. They can be easily restored if needed.
> 
> Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
> Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> ---
>  src/ipa/libipa/exposure_mode_helper.cpp | 25 -------------------------
>  src/ipa/libipa/exposure_mode_helper.h   |  5 -----
>  2 files changed, 30 deletions(-)
> 
> diff --git a/src/ipa/libipa/exposure_mode_helper.cpp b/src/ipa/libipa/exposure_mode_helper.cpp
> index 61ad142498..3e600a5c76 100644
> --- a/src/ipa/libipa/exposure_mode_helper.cpp
> +++ b/src/ipa/libipa/exposure_mode_helper.cpp
> @@ -294,31 +294,6 @@ ExposureModeHelper::splitExposure(utils::Duration exposure) const
>                  exposure / (exposureTime * gain * quantGain) };
>  }
>  
> -/**
> - * \fn ExposureModeHelper::minExposureTime()
> - * \brief Retrieve the configured minimum exposure time limit set through
> - * setLimits()
> - * \return The minExposureTime_ value
> - */
> -
> -/**
> - * \fn ExposureModeHelper::maxExposureTime()
> - * \brief Retrieve the configured maximum exposure time set through setLimits()
> - * \return The maxExposureTime_ value
> - */
> -
> -/**
> - * \fn ExposureModeHelper::minGain()
> - * \brief Retrieve the configured minimum gain set through setLimits()
> - * \return The minGain_ value
> - */
> -
> -/**
> - * \fn ExposureModeHelper::maxGain()
> - * \brief Retrieve the configured maximum gain set through setLimits()
> - * \return The maxGain_ value
> - */
> -
>  } /* namespace ipa */
>  
>  } /* namespace libcamera */
> diff --git a/src/ipa/libipa/exposure_mode_helper.h b/src/ipa/libipa/exposure_mode_helper.h
> index 1a77bf4da8..d33a0fd822 100644
> --- a/src/ipa/libipa/exposure_mode_helper.h
> +++ b/src/ipa/libipa/exposure_mode_helper.h
> @@ -40,11 +40,6 @@ public:
>  
>         [[nodiscard]] Result splitExposure(utils::Duration exposure) const;
>  
> -       utils::Duration minExposureTime() const { return minExposureTime_; }
> -       utils::Duration maxExposureTime() const { return maxExposureTime_; }
> -       double minGain() const { return minGain_; }
> -       double maxGain() const { return maxGain_; }
> -
>  private:
>         utils::Duration clampExposureTime(utils::Duration exposureTime,
>                                           double *quantizationGain = nullptr) const;
> -- 
> 2.56.0
>

Patch
diff mbox series

diff --git a/src/ipa/libipa/exposure_mode_helper.cpp b/src/ipa/libipa/exposure_mode_helper.cpp
index 61ad142498..3e600a5c76 100644
--- a/src/ipa/libipa/exposure_mode_helper.cpp
+++ b/src/ipa/libipa/exposure_mode_helper.cpp
@@ -294,31 +294,6 @@  ExposureModeHelper::splitExposure(utils::Duration exposure) const
 		 exposure / (exposureTime * gain * quantGain) };
 }
 
-/**
- * \fn ExposureModeHelper::minExposureTime()
- * \brief Retrieve the configured minimum exposure time limit set through
- * setLimits()
- * \return The minExposureTime_ value
- */
-
-/**
- * \fn ExposureModeHelper::maxExposureTime()
- * \brief Retrieve the configured maximum exposure time set through setLimits()
- * \return The maxExposureTime_ value
- */
-
-/**
- * \fn ExposureModeHelper::minGain()
- * \brief Retrieve the configured minimum gain set through setLimits()
- * \return The minGain_ value
- */
-
-/**
- * \fn ExposureModeHelper::maxGain()
- * \brief Retrieve the configured maximum gain set through setLimits()
- * \return The maxGain_ value
- */
-
 } /* namespace ipa */
 
 } /* namespace libcamera */
diff --git a/src/ipa/libipa/exposure_mode_helper.h b/src/ipa/libipa/exposure_mode_helper.h
index 1a77bf4da8..d33a0fd822 100644
--- a/src/ipa/libipa/exposure_mode_helper.h
+++ b/src/ipa/libipa/exposure_mode_helper.h
@@ -40,11 +40,6 @@  public:
 
 	[[nodiscard]] Result splitExposure(utils::Duration exposure) const;
 
-	utils::Duration minExposureTime() const { return minExposureTime_; }
-	utils::Duration maxExposureTime() const { return maxExposureTime_; }
-	double minGain() const { return minGain_; }
-	double maxGain() const { return maxGain_; }
-
 private:
 	utils::Duration clampExposureTime(utils::Duration exposureTime,
 					  double *quantizationGain = nullptr) const;