[v3,21/21] ipa: rppx1: Add uncalibrated tuning file

28359 diff mbox series

Enable algorithms that don't need any specific tuning data.

Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
---
 src/ipa/rppx1/data/meson.build       |  1 +
 src/ipa/rppx1/data/uncalibrated.yaml | 11 +++++++++++
 2 files changed, 12 insertions(+)
 create mode 100644 src/ipa/rppx1/data/uncalibrated.yaml

Hi Barnabás

On Fri, Sep 18, 2026 at 02:09:49PM +0200, Barnabás Pőcze wrote:
> Enable algorithms that don't need any specific tuning data.
>
> Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
> ---
>  src/ipa/rppx1/data/meson.build       |  1 +
>  src/ipa/rppx1/data/uncalibrated.yaml | 11 +++++++++++
>  2 files changed, 12 insertions(+)
>  create mode 100644 src/ipa/rppx1/data/uncalibrated.yaml
>
> diff --git a/src/ipa/rppx1/data/meson.build b/src/ipa/rppx1/data/meson.build
> index d1eb321758..b18511441b 100644
> --- a/src/ipa/rppx1/data/meson.build
> +++ b/src/ipa/rppx1/data/meson.build
> @@ -1,6 +1,7 @@
>  # SPDX-License-Identifier: CC0-1.0
>
>  conf_files = files([
> +    'uncalibrated.yaml',
>  ])
>
>  install_data(conf_files,
> diff --git a/src/ipa/rppx1/data/uncalibrated.yaml b/src/ipa/rppx1/data/uncalibrated.yaml
> new file mode 100644
> index 0000000000..3057df83b0
> --- /dev/null
> +++ b/src/ipa/rppx1/data/uncalibrated.yaml
> @@ -0,0 +1,11 @@
> +# SPDX-License-Identifier: CC0-1.0
> +%YAML 1.1
> +---
> +version: 1
> +algorithms:
> +  - Agc:
> +  - Awb:
> +  - BlackLevelCorrection:
> +  - Ccm:
> +  - GammaOutCorrection:

Is it any useful to instantiate Ccm and Gamma without tuning data ?

Also, could you upstream the imx219 and imx708 tuning files as well ?

Thanks
  j

> +...
> --
> 2.55.0
>

2026. 09. 25. 10:33 keltezéssel, Jacopo Mondi írta:
> Hi Barnabás
> 
> On Fri, Sep 18, 2026 at 02:09:49PM +0200, Barnabás Pőcze wrote:
>> Enable algorithms that don't need any specific tuning data.
>>
>> Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
>> ---
>>   src/ipa/rppx1/data/meson.build       |  1 +
>>   src/ipa/rppx1/data/uncalibrated.yaml | 11 +++++++++++
>>   2 files changed, 12 insertions(+)
>>   create mode 100644 src/ipa/rppx1/data/uncalibrated.yaml
>>
>> diff --git a/src/ipa/rppx1/data/meson.build b/src/ipa/rppx1/data/meson.build
>> index d1eb321758..b18511441b 100644
>> --- a/src/ipa/rppx1/data/meson.build
>> +++ b/src/ipa/rppx1/data/meson.build
>> @@ -1,6 +1,7 @@
>>   # SPDX-License-Identifier: CC0-1.0
>>
>>   conf_files = files([
>> +    'uncalibrated.yaml',
>>   ])
>>
>>   install_data(conf_files,
>> diff --git a/src/ipa/rppx1/data/uncalibrated.yaml b/src/ipa/rppx1/data/uncalibrated.yaml
>> new file mode 100644
>> index 0000000000..3057df83b0
>> --- /dev/null
>> +++ b/src/ipa/rppx1/data/uncalibrated.yaml
>> @@ -0,0 +1,11 @@
>> +# SPDX-License-Identifier: CC0-1.0
>> +%YAML 1.1
>> +---
>> +version: 1
>> +algorithms:
>> +  - Agc:
>> +  - Awb:
>> +  - BlackLevelCorrection:
>> +  - Ccm:
>> +  - GammaOutCorrection:
> 
> Is it any useful to instantiate Ccm and Gamma without tuning data ?

`Ccm` provides the user with the ability to set a manual color correction matrix,
I think that's useful. And `GammaOutCorrection` applies a default correction of 2.2
and provides the `Gamma` control.


> 
> Also, could you upstream the imx219 and imx708 tuning files as well ?
> 
> Thanks
>    j
> 
>> +...
>> --
>> 2.55.0
>>