| Message ID | 20260918120949.191668-8-barnabas.pocze@ideasonboard.com |
|---|---|
| State | New |
| Headers | show |
| Series |
|
| Related | show |
Quoting Barnabás Pőcze (2026-09-18 13:09:35) > Require at least 2, which is reasonable. > > Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com> > --- > src/ipa/libipa/gamma.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/ipa/libipa/gamma.h b/src/ipa/libipa/gamma.h > index 9954f94ba2..e5ac3f96f5 100644 > --- a/src/ipa/libipa/gamma.h > +++ b/src/ipa/libipa/gamma.h > @@ -63,6 +63,8 @@ protected: > template<unsigned int NLutNodes, typename UQ> > class GammaAlgorithm : public GammaAlgorithmBase > { > + static_assert(NLutNodes >= 2); > + 2 sounds quite low, but I don't know what an expected reasonable minimum is, other than ... more than one so ... Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > public: > GammaAlgorithm() > : GammaAlgorithmBase(NLutNodes) > -- > 2.55.0 >
2026. 09. 18. 18:35 keltezéssel, Kieran Bingham írta: > Quoting Barnabás Pőcze (2026-09-18 13:09:35) >> Require at least 2, which is reasonable. >> >> Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com> >> --- >> src/ipa/libipa/gamma.h | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/src/ipa/libipa/gamma.h b/src/ipa/libipa/gamma.h >> index 9954f94ba2..e5ac3f96f5 100644 >> --- a/src/ipa/libipa/gamma.h >> +++ b/src/ipa/libipa/gamma.h >> @@ -63,6 +63,8 @@ protected: >> template<unsigned int NLutNodes, typename UQ> >> class GammaAlgorithm : public GammaAlgorithmBase >> { >> + static_assert(NLutNodes >= 2); >> + > > 2 sounds quite low, but I don't know what an expected reasonable minimum > is, other than ... more than one so ... "reasonable" might have been an overstatement to be honest, it's just the absolute minimum for the algorithm. > > > Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > >> public: >> GammaAlgorithm() >> : GammaAlgorithmBase(NLutNodes) >> -- >> 2.55.0 >>
diff --git a/src/ipa/libipa/gamma.h b/src/ipa/libipa/gamma.h index 9954f94ba2..e5ac3f96f5 100644 --- a/src/ipa/libipa/gamma.h +++ b/src/ipa/libipa/gamma.h @@ -63,6 +63,8 @@ protected: template<unsigned int NLutNodes, typename UQ> class GammaAlgorithm : public GammaAlgorithmBase { + static_assert(NLutNodes >= 2); + public: GammaAlgorithm() : GammaAlgorithmBase(NLutNodes)
Require at least 2, which is reasonable. Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com> --- src/ipa/libipa/gamma.h | 2 ++ 1 file changed, 2 insertions(+)