| Message ID | 20260918120949.191668-7-barnabas.pocze@ideasonboard.com |
|---|---|
| State | New |
| Headers | show |
| Series |
|
| Related | show |
Quoting Barnabás Pőcze (2026-09-18 13:09:34) > The control has been updated to be writable, but that change > failed to adjust the `direction` appropriately. So do that. > > Fixes: 4d2618fb1096 ("libcamera: controls: Update the ColourTemperature control to be writable") > Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com> > --- > src/libcamera/control_ids_core.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml > index 89991d03d7..e87c0bb132 100644 > --- a/src/libcamera/control_ids_core.yaml > +++ b/src/libcamera/control_ids_core.yaml > @@ -598,7 +598,7 @@ controls: > > - ColourTemperature: > type: int32_t > - direction: out > + direction: inout Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > description: | > ColourTemperature of the frame, in kelvin. > > -- > 2.55.0 >
Hi Barnabás On Fri, Sep 18, 2026 at 02:09:34PM +0200, Barnabás Pőcze wrote: > The control has been updated to be writable, but that change > failed to adjust the `direction` appropriately. So do that. > > Fixes: 4d2618fb1096 ("libcamera: controls: Update the ColourTemperature control to be writable") > Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com> Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> Thanks j > --- > src/libcamera/control_ids_core.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml > index 89991d03d7..e87c0bb132 100644 > --- a/src/libcamera/control_ids_core.yaml > +++ b/src/libcamera/control_ids_core.yaml > @@ -598,7 +598,7 @@ controls: > > - ColourTemperature: > type: int32_t > - direction: out > + direction: inout > description: | > ColourTemperature of the frame, in kelvin. > > -- > 2.55.0 >
diff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml index 89991d03d7..e87c0bb132 100644 --- a/src/libcamera/control_ids_core.yaml +++ b/src/libcamera/control_ids_core.yaml @@ -598,7 +598,7 @@ controls: - ColourTemperature: type: int32_t - direction: out + direction: inout description: | ColourTemperature of the frame, in kelvin.
The control has been updated to be writable, but that change failed to adjust the `direction` appropriately. So do that. Fixes: 4d2618fb1096 ("libcamera: controls: Update the ColourTemperature control to be writable") Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com> --- src/libcamera/control_ids_core.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)