[libcamera-devel,2/9] fixup: Use the term 'Idle' for Ae/AnalogueGain state
diff mbox series

Message ID 20220701154701.354052-2-jacopo@jmondi.org
State Superseded, archived
Headers show
Series
  • [libcamera-devel,1/9] controls: Reorganize the AE-related controls
Related show

Commit Message

Jacopo Mondi July 1, 2022, 3:46 p.m. UTC
The Auto-Focus controls use the word "Idle" in place of "Inactive".
Use the same term for consistency.

Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
---
 src/libcamera/control_ids.yaml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Nicolas Dufresne via libcamera-devel Aug. 3, 2022, 2:04 p.m. UTC | #1
On Fri, Jul 01, 2022 at 05:46:54PM +0200, Jacopo Mondi wrote:
> The Auto-Focus controls use the word "Idle" in place of "Inactive".
> Use the same term for consistency.
> 
> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>

Acked-by: Paul Elder <paul.elder@ideasonboard.com>

> ---
>  src/libcamera/control_ids.yaml | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml
> index 21275fcb9a83..59770e63aead 100644
> --- a/src/libcamera/control_ids.yaml
> +++ b/src/libcamera/control_ids.yaml
> @@ -22,7 +22,7 @@ controls:
>          \sa ExposureTimeMode
>  
>        enum:
> -        - name: AeStateInactive
> +        - name: AeStateIdle
>            value: 0
>            description: |
>              The AE algorithm is inactive.
> @@ -944,7 +944,7 @@ controls:
>  
>          Current state of the AWB algorithm.
>        enum:
> -        - name: AwbStateInactive
> +        - name: AwbStateIdle
>            value: 0
>            description: The AWB algorithm is inactive.
>          - name: AwbStateSearching
> -- 
> 2.36.1
>

Patch
diff mbox series

diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml
index 21275fcb9a83..59770e63aead 100644
--- a/src/libcamera/control_ids.yaml
+++ b/src/libcamera/control_ids.yaml
@@ -22,7 +22,7 @@  controls:
         \sa ExposureTimeMode
 
       enum:
-        - name: AeStateInactive
+        - name: AeStateIdle
           value: 0
           description: |
             The AE algorithm is inactive.
@@ -944,7 +944,7 @@  controls:
 
         Current state of the AWB algorithm.
       enum:
-        - name: AwbStateInactive
+        - name: AwbStateIdle
           value: 0
           description: The AWB algorithm is inactive.
         - name: AwbStateSearching