[libcamera-devel,8/9] fixup: Minor changes in ExposureTimeMode
diff mbox series

Message ID 20220701154701.354052-8-jacopo@jmondi.org
State Superseded, archived
Headers show
Series
  • [libcamera-devel,1/9] controls: Reorganize the AE-related controls
Related show

Commit Message

Jacopo Mondi July 1, 2022, 3:47 p.m. UTC
slightly modify the ExposureTime modes description.

Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
---
 src/libcamera/control_ids.yaml | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

Comments

Nicolas Dufresne via libcamera-devel Aug. 3, 2022, 2:48 p.m. UTC | #1
On Fri, Jul 01, 2022 at 05:47:00PM +0200, Jacopo Mondi wrote:
> slightly modify the ExposureTime modes description.
> 
> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>

Acked-by: Paul Elder <paul.elder@ideasonboard.com>

> ---
>  src/libcamera/control_ids.yaml | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml
> index 225377cf9e76..1f22b9b35036 100644
> --- a/src/libcamera/control_ids.yaml
> +++ b/src/libcamera/control_ids.yaml
> @@ -260,20 +260,20 @@ controls:
>            value: 0
>            description: |
>              The exposure time will be calculated automatically and set by the
> -            AE algorithm. If ExposureTime is set while this mode is active, it
> -            will be ignored, and it will also not be retained.
> +            AE algorithm.
> +
> +            If ExposureTime is set while this mode is active, it will be
> +            ignored, and it will also not be retained.
>          - name: ExposureTimeModeManual
>            value: 1
>            description: |
> -            The exposure time will not be updated by the AE algorithm. It will
> -            come from the last calculated value when the mode was Auto, or from
> -            the value specified in ExposureTime.
> +            The exposure time will not be updated by the AE algorithm.
>  
>              When transitioning from Auto to Manual mode, the last computed
>              exposure value is used until a new value is specified through the
>              ExposureTime control. If an ExposureTime value is specified in the
>              same request where the ExposureTimeMode is changed from Auto to
> -            Manual, the provided ExposureTime is applied.
> +            Manual, the provided ExposureTime is applied immediately.
>  
>    - AnalogueGain:
>        type: float
> -- 
> 2.36.1
>

Patch
diff mbox series

diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml
index 225377cf9e76..1f22b9b35036 100644
--- a/src/libcamera/control_ids.yaml
+++ b/src/libcamera/control_ids.yaml
@@ -260,20 +260,20 @@  controls:
           value: 0
           description: |
             The exposure time will be calculated automatically and set by the
-            AE algorithm. If ExposureTime is set while this mode is active, it
-            will be ignored, and it will also not be retained.
+            AE algorithm.
+
+            If ExposureTime is set while this mode is active, it will be
+            ignored, and it will also not be retained.
         - name: ExposureTimeModeManual
           value: 1
           description: |
-            The exposure time will not be updated by the AE algorithm. It will
-            come from the last calculated value when the mode was Auto, or from
-            the value specified in ExposureTime.
+            The exposure time will not be updated by the AE algorithm.
 
             When transitioning from Auto to Manual mode, the last computed
             exposure value is used until a new value is specified through the
             ExposureTime control. If an ExposureTime value is specified in the
             same request where the ExposureTimeMode is changed from Auto to
-            Manual, the provided ExposureTime is applied.
+            Manual, the provided ExposureTime is applied immediately.
 
   - AnalogueGain:
       type: float