[libcamera-devel,6/9] fixup: Reword ExposureTimeMode

16516 diff mbox series

Slightly reword the first part of the control definition.

Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
---
 src/libcamera/control_ids.yaml | 16 +++++-----------
 1 file changed, 5 insertions(+), 11 deletions(-)

Hi Jacopo,

On Fri, Jul 01, 2022 at 05:46:58PM +0200, Jacopo Mondi wrote:
> Slightly reword the first part of the control definition.
> 
> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
> ---
>  src/libcamera/control_ids.yaml | 16 +++++-----------
>  1 file changed, 5 insertions(+), 11 deletions(-)
> 
> diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml
> index b062b7e234a6..e6676a149795 100644
> --- a/src/libcamera/control_ids.yaml
> +++ b/src/libcamera/control_ids.yaml
> @@ -203,21 +203,15 @@ controls:
>          Controls the source of the exposure time that is applied to the image
>          sensor. When set to Auto, the AE algorithm computes the exposure time
>          and configures the image sensor accordingly. When set to Manual,
> -        exposure time specified in ExposureTime is applied to the image sensor.
> -        If ExposureTime is not set, then the value last computed by the AE
> -        algorithm when the mode was Auto will be used.
> +        the value of the ExposureTime control is used.
>  
> -        If ExposureTime is not set and the mode is ExposureTimeModeManual and
> -        AE was never Auto (either because the camera started in Manual mode,
> +        When transitioning from Auto to Manual mode and no ExposureTime control
> +        is provided by the application, the last value computed by the AE
> +        algorithm when the mode was Auto will be used. If the ExposureTimeMode
> +        was never set to Auto (either because the camera started in Manual mode,
>          or Auto is not supported by the camera), the camera should use a
>          best-effort default value.
>  
> -        When ExposureTimeMode is set Auto, the value set in ExposureTime is
> -        ignored and is not retained.

I think this part should explicitly be kept in some form.

The rest looks good.


Paul


> This means that if ExposureTimeMode is set
> -        to Manual and ExposureTime is not also set, the exposure time that
> -        was last computed by the AE algorithm while the mode was Auto will be
> -        applied to the sensor.
> -
>          If ExposureTimeModeManual is supported, the ExposureTime control must
>          also be supported.
>  
> -- 
> 2.36.1
>

On Wed, Aug 03, 2022 at 11:22:56PM +0900, Paul Elder via libcamera-devel wrote:
> Hi Jacopo,
> 
> On Fri, Jul 01, 2022 at 05:46:58PM +0200, Jacopo Mondi wrote:
> > Slightly reword the first part of the control definition.
> > 
> > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
> > ---
> >  src/libcamera/control_ids.yaml | 16 +++++-----------
> >  1 file changed, 5 insertions(+), 11 deletions(-)
> > 
> > diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml
> > index b062b7e234a6..e6676a149795 100644
> > --- a/src/libcamera/control_ids.yaml
> > +++ b/src/libcamera/control_ids.yaml
> > @@ -203,21 +203,15 @@ controls:
> >          Controls the source of the exposure time that is applied to the image
> >          sensor. When set to Auto, the AE algorithm computes the exposure time
> >          and configures the image sensor accordingly. When set to Manual,
> > -        exposure time specified in ExposureTime is applied to the image sensor.
> > -        If ExposureTime is not set, then the value last computed by the AE
> > -        algorithm when the mode was Auto will be used.
> > +        the value of the ExposureTime control is used.
> >  
> > -        If ExposureTime is not set and the mode is ExposureTimeModeManual and
> > -        AE was never Auto (either because the camera started in Manual mode,
> > +        When transitioning from Auto to Manual mode and no ExposureTime control
> > +        is provided by the application, the last value computed by the AE
> > +        algorithm when the mode was Auto will be used. If the ExposureTimeMode
> > +        was never set to Auto (either because the camera started in Manual mode,
> >          or Auto is not supported by the camera), the camera should use a
> >          best-effort default value.
> >  
> > -        When ExposureTimeMode is set Auto, the value set in ExposureTime is
> > -        ignored and is not retained.
> 
> I think this part should explicitly be kept in some form.

Oh, I forgot, it's in the enum value description.


Acked-by: Paul Elder <paul.elder@ideasonboard.com>

> 
> The rest looks good.
> 
> 
> 
> > This means that if ExposureTimeMode is set
> > -        to Manual and ExposureTime is not also set, the exposure time that
> > -        was last computed by the AE algorithm while the mode was Auto will be
> > -        applied to the sensor.
> > -
> >          If ExposureTimeModeManual is supported, the ExposureTime control must
> >          also be supported.
> >  
> > -- 
> > 2.36.1
> >