Patch Detail
Show a patch.
GET /api/patches/26762/?format=api
{ "id": 26762, "url": "https://patchwork.libcamera.org/api/patches/26762/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26762/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260515093309.28560-1-stefan.klug@ideasonboard.com>", "date": "2026-05-15T09:32:58", "name": "Fix docs deployment", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "49b585a55c80c3a11da5849ed55bfe0b626ec459", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26762/mbox/", "series": [ { "id": 5949, "url": "https://patchwork.libcamera.org/api/series/5949/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5949", "date": "2026-05-15T09:32:58", "name": "Fix docs deployment", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5949/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26762/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26762/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 62ECCBDCBD\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 15 May 2026 09:33:16 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 50F4E6301E;\n\tFri, 15 May 2026 11:33:15 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0BC6B62010\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 15 May 2026 11:33:13 +0200 (CEST)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:6869:37b8:49ee:a0a5])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 0730880B;\n\tFri, 15 May 2026 11:33:03 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"LydbRPIP\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1778837584;\n\tbh=vGfk1AwkT872vAbbGZr39bmwOfFig7ZZ4fXF/XgPwfU=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=LydbRPIPcyjsMyuBJjbK0TMAP3QEJ2gCjQwbpHK8uJen5/BX22rsvNfFwWWOpvhgj\n\t1x2gblop1ThrVgbhCRtnU4u24yYRzvdEDXZycXCa/NrKcns+TVfF4XQEHw1ame8Igu\n\tdYj5Pp6/Lxu1hTb9O/byHVwkrp6zh5BXbJwmCP1M=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>", "Subject": "[PATCH] Fix docs deployment", "Date": "Fri, 15 May 2026 11:32:58 +0200", "Message-ID": "<20260515093309.28560-1-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.51.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The last minute change in commit 95b3488dbf45 (\"Deploy docs to\ndocs.libcamera.org\") had a bug that causes the deploy stage to never\nrun. As shown in\nhttps://docs.gitlab.com/ci/jobs/job_rules/#negate-expressions the\nexpression needs to be quoted. It is not intuitively obvious why !($VAR\n|| $VAR2) is allowed without quoting but !$VAR needs quoting. Quote it\nto make the deploy step work.\n\nFixes: 95b3488dbf45 (\"Deploy docs to docs.libcamera.org\")\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n---\n gitlab-ci.yml | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/gitlab-ci.yml b/gitlab-ci.yml\nindex c87aa239e50a..e3274ca56e20 100644\n--- a/gitlab-ci.yml\n+++ b/gitlab-ci.yml\n@@ -452,7 +452,7 @@ deploy-docs:\n - .libcamera-ci.debian:13\n - .libcamera-ci.scripts\n rules:\n- - if: !$DEPLOY_DESTINATION\n+ - if: \"!$DEPLOY_DESTINATION\"\n when: never\n - if: $CI_COMMIT_BRANCH == $CI_DEFAULT_BRANCH\n - if: $CI_COMMIT_TAG =~ /^v([0-9]+\\.)*[0-9]+$/\n", "prefixes": [] }