Fix docs deployment
diff mbox series

Message ID 20260515093309.28560-1-stefan.klug@ideasonboard.com
State New
Headers show
Series
  • Fix docs deployment
Related show

Commit Message

Stefan Klug May 15, 2026, 9:32 a.m. UTC 
The last minute change in commit 95b3488dbf45 ("Deploy docs to
docs.libcamera.org") had a bug that causes the deploy stage to never
run. As shown in
https://docs.gitlab.com/ci/jobs/job_rules/#negate-expressions the
expression needs to be quoted. It is not intuitively obvious why !($VAR
|| $VAR2) is allowed without quoting but !$VAR needs quoting. Quote it
to make the deploy step work.

Fixes: 95b3488dbf45 ("Deploy docs to docs.libcamera.org")
Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>
---
 gitlab-ci.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Barnabás Pőcze May 15, 2026, 9:45 a.m. UTC | #1 
2026. 05. 15. 11:32 keltezéssel, Stefan Klug írta:
> The last minute change in commit 95b3488dbf45 ("Deploy docs to
> docs.libcamera.org") had a bug that causes the deploy stage to never
> run. As shown in
> https://docs.gitlab.com/ci/jobs/job_rules/#negate-expressions the
> expression needs to be quoted. It is not intuitively obvious why !($VAR
> || $VAR2) is allowed without quoting but !$VAR needs quoting. Quote it
> to make the deploy step work.
> 
> Fixes: 95b3488dbf45 ("Deploy docs to docs.libcamera.org")
> Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>
> ---

Oops... sorry. I wonder why this didn't cause a pipeline failure.

Reviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>


>   gitlab-ci.yml | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/gitlab-ci.yml b/gitlab-ci.yml
> index c87aa239e50a..e3274ca56e20 100644
> --- a/gitlab-ci.yml
> +++ b/gitlab-ci.yml
> @@ -452,7 +452,7 @@ deploy-docs:
>       - .libcamera-ci.debian:13
>       - .libcamera-ci.scripts
>     rules:
> -    - if: !$DEPLOY_DESTINATION
> +    - if: "!$DEPLOY_DESTINATION"
>         when: never
>       - if: $CI_COMMIT_BRANCH == $CI_DEFAULT_BRANCH
>       - if: $CI_COMMIT_TAG =~ /^v([0-9]+\.)*[0-9]+$/
Laurent Pinchart May 15, 2026, 12:29 p.m. UTC | #2 
On Fri, May 15, 2026 at 11:32:58AM +0200, Stefan Klug wrote:
> The last minute change in commit 95b3488dbf45 ("Deploy docs to
> docs.libcamera.org") had a bug that causes the deploy stage to never
> run. As shown in
> https://docs.gitlab.com/ci/jobs/job_rules/#negate-expressions the
> expression needs to be quoted. It is not intuitively obvious why !($VAR
> || $VAR2) is allowed without quoting but !$VAR needs quoting. Quote it
> to make the deploy step work.
> 
> Fixes: 95b3488dbf45 ("Deploy docs to docs.libcamera.org")
> Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  gitlab-ci.yml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/gitlab-ci.yml b/gitlab-ci.yml
> index c87aa239e50a..e3274ca56e20 100644
> --- a/gitlab-ci.yml
> +++ b/gitlab-ci.yml
> @@ -452,7 +452,7 @@ deploy-docs:
>      - .libcamera-ci.debian:13
>      - .libcamera-ci.scripts
>    rules:
> -    - if: !$DEPLOY_DESTINATION
> +    - if: "!$DEPLOY_DESTINATION"
>        when: never
>      - if: $CI_COMMIT_BRANCH == $CI_DEFAULT_BRANCH
>      - if: $CI_COMMIT_TAG =~ /^v([0-9]+\.)*[0-9]+$/

Patch
diff mbox series 

diff --git a/gitlab-ci.yml b/gitlab-ci.yml
index c87aa239e50a..e3274ca56e20 100644
--- a/gitlab-ci.yml
+++ b/gitlab-ci.yml
@@ -452,7 +452,7 @@  deploy-docs:
     - .libcamera-ci.debian:13
     - .libcamera-ci.scripts
   rules:
-    - if: !$DEPLOY_DESTINATION
+    - if: "!$DEPLOY_DESTINATION"
       when: never
     - if: $CI_COMMIT_BRANCH == $CI_DEFAULT_BRANCH
     - if: $CI_COMMIT_TAG =~ /^v([0-9]+\.)*[0-9]+$/