From patchwork Fri May 15 09:32:58 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Stefan Klug X-Patchwork-Id: 26762 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 62ECCBDCBD for ; Fri, 15 May 2026 09:33:16 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 50F4E6301E; Fri, 15 May 2026 11:33:15 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="LydbRPIP"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 0BC6B62010 for ; Fri, 15 May 2026 11:33:13 +0200 (CEST) Received: from ideasonboard.com (unknown [IPv6:2a00:6020:448c:6c00:6869:37b8:49ee:a0a5]) by perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 0730880B; Fri, 15 May 2026 11:33:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1778837584; bh=vGfk1AwkT872vAbbGZr39bmwOfFig7ZZ4fXF/XgPwfU=; h=From:To:Cc:Subject:Date:From; b=LydbRPIPcyjsMyuBJjbK0TMAP3QEJ2gCjQwbpHK8uJen5/BX22rsvNfFwWWOpvhgj 1x2gblop1ThrVgbhCRtnU4u24yYRzvdEDXZycXCa/NrKcns+TVfF4XQEHw1ame8Igu dYj5Pp6/Lxu1hTb9O/byHVwkrp6zh5BXbJwmCP1M= From: Stefan Klug To: libcamera-devel@lists.libcamera.org Cc: Stefan Klug Subject: [PATCH] Fix docs deployment Date: Fri, 15 May 2026 11:32:58 +0200 Message-ID: <20260515093309.28560-1-stefan.klug@ideasonboard.com> X-Mailer: git-send-email 2.51.0 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The last minute change in commit 95b3488dbf45 ("Deploy docs to docs.libcamera.org") had a bug that causes the deploy stage to never run. As shown in https://docs.gitlab.com/ci/jobs/job_rules/#negate-expressions the expression needs to be quoted. It is not intuitively obvious why !($VAR || $VAR2) is allowed without quoting but !$VAR needs quoting. Quote it to make the deploy step work. Fixes: 95b3488dbf45 ("Deploy docs to docs.libcamera.org") Signed-off-by: Stefan Klug Reviewed-by: Barnabás Pőcze Reviewed-by: Laurent Pinchart --- gitlab-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gitlab-ci.yml b/gitlab-ci.yml index c87aa239e50a..e3274ca56e20 100644 --- a/gitlab-ci.yml +++ b/gitlab-ci.yml @@ -452,7 +452,7 @@ deploy-docs: - .libcamera-ci.debian:13 - .libcamera-ci.scripts rules: - - if: !$DEPLOY_DESTINATION + - if: "!$DEPLOY_DESTINATION" when: never - if: $CI_COMMIT_BRANCH == $CI_DEFAULT_BRANCH - if: $CI_COMMIT_TAG =~ /^v([0-9]+\.)*[0-9]+$/