[{"id":38904,"web_url":"https://patchwork.libcamera.org/comment/38904/","msgid":"","date":"2026-05-15T09:45:55","subject":"Re: [PATCH] Fix docs deployment","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2026. 05. 15. 11:32 keltezéssel, Stefan Klug írta:\n> The last minute change in commit 95b3488dbf45 (\"Deploy docs to\n> docs.libcamera.org\") had a bug that causes the deploy stage to never\n> run. As shown in\n> https://docs.gitlab.com/ci/jobs/job_rules/#negate-expressions the\n> expression needs to be quoted. It is not intuitively obvious why !($VAR\n> || $VAR2) is allowed without quoting but !$VAR needs quoting. Quote it\n> to make the deploy step work.\n> \n> Fixes: 95b3488dbf45 (\"Deploy docs to docs.libcamera.org\")\n> Signed-off-by: Stefan Klug \n> ---\n\nOops... sorry. I wonder why this didn't cause a pipeline failure.\n\nReviewed-by: Barnabás Pőcze \n\n\n> gitlab-ci.yml | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/gitlab-ci.yml b/gitlab-ci.yml\n> index c87aa239e50a..e3274ca56e20 100644\n> --- a/gitlab-ci.yml\n> +++ b/gitlab-ci.yml\n> @@ -452,7 +452,7 @@ deploy-docs:\n> - .libcamera-ci.debian:13\n> - .libcamera-ci.scripts\n> rules:\n> - - if: !$DEPLOY_DESTINATION\n> + - if: \"!$DEPLOY_DESTINATION\"\n> when: never\n> - if: $CI_COMMIT_BRANCH == $CI_DEFAULT_BRANCH\n> - if: $CI_COMMIT_TAG =~ /^v([0-9]+\\.)*[0-9]+$/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2BEC4BDCBC\n\tfor ;\n\tFri, 15 May 2026 09:46:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 19D2B6301E;\n\tFri, 15 May 2026 11:46:00 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5BC8C62010\n\tfor ;\n\tFri, 15 May 2026 11:45:59 +0200 (CEST)","from [192.168.33.29] (185.221.143.105.nat.pool.zt.hu\n\t[185.221.143.105])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 48E9A454;\n\tFri, 15 May 2026 11:45:49 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"dn1+0g3r\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1778838349;\n\tbh=aN9+ja1THsmIHPU5F493ydnpsrrFEeE74acLbTPK4kY=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=dn1+0g3rp62xOgO0gZTmiQ45bAqHvEEQl/JMQRR65fvfaoW0gf/zdOf+eaBMzzryv\n\tpFxczjSDTYVV+Edj9a9dJziPjWQ5z3QHpMa7vqcwXtWpOXEXH6tQdznLfxaXh6I5MH\n\tM8Ea+egUBs9HhjpTjNRmnSgofnz2cZtKrkro0NEs=","Message-ID":"","Date":"Fri, 15 May 2026 11:45:55 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] Fix docs deployment","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20260515093309.28560-1-stefan.klug@ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20260515093309.28560-1-stefan.klug@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":38905,"web_url":"https://patchwork.libcamera.org/comment/38905/","msgid":"<20260515122918.GC52035@killaraus.ideasonboard.com>","date":"2026-05-15T12:29:18","subject":"Re: [PATCH] Fix docs deployment","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Fri, May 15, 2026 at 11:32:58AM +0200, Stefan Klug wrote:\n> The last minute change in commit 95b3488dbf45 (\"Deploy docs to\n> docs.libcamera.org\") had a bug that causes the deploy stage to never\n> run. As shown in\n> https://docs.gitlab.com/ci/jobs/job_rules/#negate-expressions the\n> expression needs to be quoted. It is not intuitively obvious why !($VAR\n> || $VAR2) is allowed without quoting but !$VAR needs quoting. Quote it\n> to make the deploy step work.\n> \n> Fixes: 95b3488dbf45 (\"Deploy docs to docs.libcamera.org\")\n> Signed-off-by: Stefan Klug \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> gitlab-ci.yml | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/gitlab-ci.yml b/gitlab-ci.yml\n> index c87aa239e50a..e3274ca56e20 100644\n> --- a/gitlab-ci.yml\n> +++ b/gitlab-ci.yml\n> @@ -452,7 +452,7 @@ deploy-docs:\n> - .libcamera-ci.debian:13\n> - .libcamera-ci.scripts\n> rules:\n> - - if: !$DEPLOY_DESTINATION\n> + - if: \"!$DEPLOY_DESTINATION\"\n> when: never\n> - if: $CI_COMMIT_BRANCH == $CI_DEFAULT_BRANCH\n> - if: $CI_COMMIT_TAG =~ /^v([0-9]+\\.)*[0-9]+$/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C2EA9BDCBD\n\tfor ;\n\tFri, 15 May 2026 12:29:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AD24B63025;\n\tFri, 15 May 2026 14:29:21 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A551362FB1\n\tfor ;\n\tFri, 15 May 2026 14:29:19 +0200 (CEST)","from killaraus.ideasonboard.com\n\t(2001-14ba-70f3-e800--a06.rev.dnainternet.fi\n\t[IPv6:2001:14ba:70f3:e800::a06])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 782BE63C;\n\tFri, 15 May 2026 14:29:09 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"wYUf8ALX\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1778848149;\n\tbh=FVgtPE7zxsnl2XRlJ2gxoatXIY2iXetD4J97PI9Aq98=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=wYUf8ALXfIUzNDIb5l/2lmHVhJSbPDEuvzVGkqNlYzuJrmrCA88VQLLDw0XLAfX8Y\n\tIJNEAhPrwFyVESdqvaDg8yYEygzQgXdUnB3C3hlG13xHCtoekdCcJyMdM1cl5gFUO2\n\tGkYsOzvAM0qiN2x//NfwepvrZm+1em47mDVY+5AI=","Date":"Fri, 15 May 2026 15:29:18 +0300","From":"Laurent Pinchart ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] Fix docs deployment","Message-ID":"<20260515122918.GC52035@killaraus.ideasonboard.com>","References":"<20260515093309.28560-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20260515093309.28560-1-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]