| Message ID | 20200922133537.258098-13-paul.elder@ideasonboard.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series |
|
| Related | show |
Hi Paul, Thank you for the patch. On Tue, Sep 22, 2020 at 10:35:11PM +0900, Paul Elder wrote: > The raspberrypi IPA clearly depends on the generated header. Add the Which generated header ? Maybe s/clearly depends/will depend/ as that's not the case yet in this patch ? > dependency. Simply add all generated headers as a dependency, instead of > walking the list of headers. ", to simplify the implementation. This will have the effect of generating all headers before compiling the IPA, which has no drawback." Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Signed-off-by: Paul Elder <paul.elder@ideasonboard.com> > > --- > New in v2 > --- > src/ipa/raspberrypi/meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/ipa/raspberrypi/meson.build b/src/ipa/raspberrypi/meson.build > index 9445cd09..27c29249 100644 > --- a/src/ipa/raspberrypi/meson.build > +++ b/src/ipa/raspberrypi/meson.build > @@ -42,7 +42,7 @@ rpi_ipa_sources = files([ > ]) > > mod = shared_module(ipa_name, > - rpi_ipa_sources, > + [rpi_ipa_sources, libcamera_generated_headers], > name_prefix : '', > include_directories : rpi_ipa_includes, > dependencies : rpi_ipa_deps,
diff --git a/src/ipa/raspberrypi/meson.build b/src/ipa/raspberrypi/meson.build index 9445cd09..27c29249 100644 --- a/src/ipa/raspberrypi/meson.build +++ b/src/ipa/raspberrypi/meson.build @@ -42,7 +42,7 @@ rpi_ipa_sources = files([ ]) mod = shared_module(ipa_name, - rpi_ipa_sources, + [rpi_ipa_sources, libcamera_generated_headers], name_prefix : '', include_directories : rpi_ipa_includes, dependencies : rpi_ipa_deps,
The raspberrypi IPA clearly depends on the generated header. Add the dependency. Simply add all generated headers as a dependency, instead of walking the list of headers. Signed-off-by: Paul Elder <paul.elder@ideasonboard.com> --- New in v2 --- src/ipa/raspberrypi/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)