| Message ID | 20200922133537.258098-8-paul.elder@ideasonboard.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series |
|
| Related | show |
Hi Paul, On Tue, Sep 22, 2020 at 10:35:06PM +0900, Paul Elder wrote: > Add licensing information for mojo in dep5. > > Signed-off-by: Paul Elder <paul.elder@ideasonboard.com> > > --- > New in v2 > --- > .reuse/dep5 | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/.reuse/dep5 b/.reuse/dep5 > index a66f27e7..0a453931 100644 > --- a/.reuse/dep5 > +++ b/.reuse/dep5 > @@ -13,3 +13,9 @@ Files: src/qcam/assets/feathericons/*.svg > Copyright: 2019 Cole Bemis (and other Feather icons contributors) > License: MIT > Comment: https://feathericons.com/ > + > +Files: utils/ipc/mojo > + utils/ipc/tools > +Copyright: Copyright 2014 The Chromium Authors. All rights reserved. > +License: BSD-3-Clause I see here https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#license-short-name that 'Clause' as actually a lowercase 'c' ? > +Source: https://chromium.googlesource.com/chromium/src.git/ Reviewed-by: Jacopo Mondi <jacopo@jmondi.org> > -- > 2.27.0 > > _______________________________________________ > libcamera-devel mailing list > libcamera-devel@lists.libcamera.org > https://lists.libcamera.org/listinfo/libcamera-devel
Hi Jacopo, On Wed, Sep 23, 2020 at 01:04:27PM +0200, Jacopo Mondi wrote: > Hi Paul, > > On Tue, Sep 22, 2020 at 10:35:06PM +0900, Paul Elder wrote: > > Add licensing information for mojo in dep5. > > > > Signed-off-by: Paul Elder <paul.elder@ideasonboard.com> > > > > --- > > New in v2 > > --- > > .reuse/dep5 | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/.reuse/dep5 b/.reuse/dep5 > > index a66f27e7..0a453931 100644 > > --- a/.reuse/dep5 > > +++ b/.reuse/dep5 > > @@ -13,3 +13,9 @@ Files: src/qcam/assets/feathericons/*.svg > > Copyright: 2019 Cole Bemis (and other Feather icons contributors) > > License: MIT > > Comment: https://feathericons.com/ > > + > > +Files: utils/ipc/mojo > > + utils/ipc/tools > > +Copyright: Copyright 2014 The Chromium Authors. All rights reserved. > > +License: BSD-3-Clause > > I see here > https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#license-short-name > > that 'Clause' as actually a lowercase 'c' ? Ah yes, you're right. This needs to be fixed for the raspberrypi entry too then. I wonder why SPDX has it capitalized then. > > +Source: https://chromium.googlesource.com/chromium/src.git/ > > Reviewed-by: Jacopo Mondi <jacopo@jmondi.org> Thanks, Paul
Hi Paul and Jacopo, On Thu, Sep 24, 2020 at 09:48:58AM +0900, paul.elder@ideasonboard.com wrote: > On Wed, Sep 23, 2020 at 01:04:27PM +0200, Jacopo Mondi wrote: > > On Tue, Sep 22, 2020 at 10:35:06PM +0900, Paul Elder wrote: > > > Add licensing information for mojo in dep5. > > > > > > Signed-off-by: Paul Elder <paul.elder@ideasonboard.com> > > > > > > --- > > > New in v2 > > > --- > > > .reuse/dep5 | 6 ++++++ > > > 1 file changed, 6 insertions(+) > > > > > > diff --git a/.reuse/dep5 b/.reuse/dep5 > > > index a66f27e7..0a453931 100644 > > > --- a/.reuse/dep5 > > > +++ b/.reuse/dep5 > > > @@ -13,3 +13,9 @@ Files: src/qcam/assets/feathericons/*.svg > > > Copyright: 2019 Cole Bemis (and other Feather icons contributors) > > > License: MIT > > > Comment: https://feathericons.com/ > > > + > > > +Files: utils/ipc/mojo > > > + utils/ipc/tools > > > +Copyright: Copyright 2014 The Chromium Authors. All rights reserved. > > > +License: BSD-3-Clause > > > > I see here > > https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#license-short-name > > > > that 'Clause' as actually a lowercase 'c' ? > > Ah yes, you're right. This needs to be fixed for the raspberrypi entry > too then. > > I wonder why SPDX has it capitalized then. I'm using the reuse lint tool (https://reuse.software/) to check that all files have a proper license, and "BSD-3-clause" is flagged as bad. The DEP5 specification states that license names are case-insensitive, while they seem to be case-sensitive for SPDX, so I'd go for BSD-3-Clause with a capital C. > > > +Source: https://chromium.googlesource.com/chromium/src.git/ > > > > Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
Hi Paul, Thank you for the patch. On Tue, Sep 22, 2020 at 10:35:06PM +0900, Paul Elder wrote: > Add licensing information for mojo in dep5. > > Signed-off-by: Paul Elder <paul.elder@ideasonboard.com> > > --- > New in v2 > --- > .reuse/dep5 | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/.reuse/dep5 b/.reuse/dep5 > index a66f27e7..0a453931 100644 > --- a/.reuse/dep5 > +++ b/.reuse/dep5 > @@ -13,3 +13,9 @@ Files: src/qcam/assets/feathericons/*.svg > Copyright: 2019 Cole Bemis (and other Feather icons contributors) > License: MIT > Comment: https://feathericons.com/ > + > +Files: utils/ipc/mojo > + utils/ipc/tools > +Copyright: Copyright 2014 The Chromium Authors. All rights reserved. 2014 only ? $ git grep Copyright utils/ipc/mojo/ utils/ipc/tools/ | sed 's/[^:]*:[/#*]* Copyright //' | sed 's/ .*//' | sort -u | head -1 2013 $ git grep Copyright utils/ipc/mojo/ utils/ipc/tools/ | sed 's/[^:]*:[/#*]* Copyright //' | sed 's/ .*//' | sort -u | tail -1 2020 How about Copyright: Copyright 2013-2020 The Chromium Authors. All rights reserved. ? Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > +License: BSD-3-Clause > +Source: https://chromium.googlesource.com/chromium/src.git/
diff --git a/.reuse/dep5 b/.reuse/dep5 index a66f27e7..0a453931 100644 --- a/.reuse/dep5 +++ b/.reuse/dep5 @@ -13,3 +13,9 @@ Files: src/qcam/assets/feathericons/*.svg Copyright: 2019 Cole Bemis (and other Feather icons contributors) License: MIT Comment: https://feathericons.com/ + +Files: utils/ipc/mojo + utils/ipc/tools +Copyright: Copyright 2014 The Chromium Authors. All rights reserved. +License: BSD-3-Clause +Source: https://chromium.googlesource.com/chromium/src.git/
Add licensing information for mojo in dep5. Signed-off-by: Paul Elder <paul.elder@ideasonboard.com> --- New in v2 --- .reuse/dep5 | 6 ++++++ 1 file changed, 6 insertions(+)