| Message ID | 20200922133537.258098-5-paul.elder@ideasonboard.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series |
|
| Related | show |
Hi Paul, On Tue, Sep 22, 2020 at 10:35:03PM +0900, Paul Elder wrote: > EventNotifier is not included; forward-declare it to satisfy the > compiler > Where is it needed ? I don't see it used in process.h > Signed-off-by: Paul Elder <paul.elder@ideasonboard.com> > > --- > New in v2 > --- > include/libcamera/internal/process.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/libcamera/internal/process.h b/include/libcamera/internal/process.h > index 458a2149..254cda85 100644 > --- a/include/libcamera/internal/process.h > +++ b/include/libcamera/internal/process.h > @@ -15,6 +15,8 @@ > > namespace libcamera { > > +class EventNotifier; > + > class Process final > { > public: > -- > 2.27.0 > > _______________________________________________ > libcamera-devel mailing list > libcamera-devel@lists.libcamera.org > https://lists.libcamera.org/listinfo/libcamera-devel
Hi Jacopo, On Wed, Sep 23, 2020 at 12:44:09PM +0200, Jacopo Mondi wrote: > Hi Paul, > > On Tue, Sep 22, 2020 at 10:35:03PM +0900, Paul Elder wrote: > > EventNotifier is not included; forward-declare it to satisfy the > > compiler > > > > Where is it needed ? I don't see it used in process.h Line 71: void sighandler(EventNotifier *notifier); Line 76: EventNotifier *sigEvent_; > > Signed-off-by: Paul Elder <paul.elder@ideasonboard.com> > > > > --- > > New in v2 > > --- > > include/libcamera/internal/process.h | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/include/libcamera/internal/process.h b/include/libcamera/internal/process.h > > index 458a2149..254cda85 100644 > > --- a/include/libcamera/internal/process.h > > +++ b/include/libcamera/internal/process.h > > @@ -15,6 +15,8 @@ > > > > namespace libcamera { > > > > +class EventNotifier; > > + > > class Process final > > { > > public: > > -- > > 2.27.0 Paul
On Thu, Sep 24, 2020 at 09:52:31AM +0900, paul.elder@ideasonboard.com wrote: > Hi Jacopo, > > On Wed, Sep 23, 2020 at 12:44:09PM +0200, Jacopo Mondi wrote: > > Hi Paul, > > > > On Tue, Sep 22, 2020 at 10:35:03PM +0900, Paul Elder wrote: > > > EventNotifier is not included; forward-declare it to satisfy the > > > compiler > > > > > > > Where is it needed ? I don't see it used in process.h > > Line 71: > void sighandler(EventNotifier *notifier); > > Line 76: > EventNotifier *sigEvent_; That's only after moving ProcessManager to process.h though. You should squash this change with 02/38. > > > Signed-off-by: Paul Elder <paul.elder@ideasonboard.com> > > > > > > --- > > > New in v2 > > > --- > > > include/libcamera/internal/process.h | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/include/libcamera/internal/process.h b/include/libcamera/internal/process.h > > > index 458a2149..254cda85 100644 > > > --- a/include/libcamera/internal/process.h > > > +++ b/include/libcamera/internal/process.h > > > @@ -15,6 +15,8 @@ > > > > > > namespace libcamera { > > > > > > +class EventNotifier; > > > + > > > class Process final > > > { > > > public:
Hi Paul, Laurent On Thu, Sep 24, 2020 at 04:14:02AM +0300, Laurent Pinchart wrote: > On Thu, Sep 24, 2020 at 09:52:31AM +0900, paul.elder@ideasonboard.com wrote: > > Hi Jacopo, > > > > On Wed, Sep 23, 2020 at 12:44:09PM +0200, Jacopo Mondi wrote: > > > Hi Paul, > > > > > > On Tue, Sep 22, 2020 at 10:35:03PM +0900, Paul Elder wrote: > > > > EventNotifier is not included; forward-declare it to satisfy the > > > > compiler > > > > > > > > > > Where is it needed ? I don't see it used in process.h > > > > Line 71: > > void sighandler(EventNotifier *notifier); > > > > Line 76: > > EventNotifier *sigEvent_; > > That's only after moving ProcessManager to process.h though. You should > squash this change with 02/38. > Ah yes, I indeed missed that! With the patch squashed Reviewed-by: Jacopo Mondi <jacopo@jmondi.org> Thanks j > > > > Signed-off-by: Paul Elder <paul.elder@ideasonboard.com> > > > > > > > > --- > > > > New in v2 > > > > --- > > > > include/libcamera/internal/process.h | 2 ++ > > > > 1 file changed, 2 insertions(+) > > > > > > > > diff --git a/include/libcamera/internal/process.h b/include/libcamera/internal/process.h > > > > index 458a2149..254cda85 100644 > > > > --- a/include/libcamera/internal/process.h > > > > +++ b/include/libcamera/internal/process.h > > > > @@ -15,6 +15,8 @@ > > > > > > > > namespace libcamera { > > > > > > > > +class EventNotifier; > > > > + > > > > class Process final > > > > { > > > > public: > > -- > Regards, > > Laurent Pinchart
diff --git a/include/libcamera/internal/process.h b/include/libcamera/internal/process.h index 458a2149..254cda85 100644 --- a/include/libcamera/internal/process.h +++ b/include/libcamera/internal/process.h @@ -15,6 +15,8 @@ namespace libcamera { +class EventNotifier; + class Process final { public:
EventNotifier is not included; forward-declare it to satisfy the compiler Signed-off-by: Paul Elder <paul.elder@ideasonboard.com> --- New in v2 --- include/libcamera/internal/process.h | 2 ++ 1 file changed, 2 insertions(+)