| Message ID | 20200915142038.28757-13-paul.elder@ideasonboard.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series |
|
| Related | show |
Hi Paul, Thanks for your patch. On 2020-09-15 23:20:27 +0900, Paul Elder wrote: > Since pipline handlers now have their own IPA interface types, it can no > longer be defined in the base class, and each pipline handler > implementation must declare it and its type themselves. Remove it from > the base class. > > Signed-off-by: Paul Elder <paul.elder@ideasonboard.com> Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se> > --- > include/libcamera/internal/pipeline_handler.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h > index a4e1b529..2018bef0 100644 > --- a/include/libcamera/internal/pipeline_handler.h > +++ b/include/libcamera/internal/pipeline_handler.h > @@ -47,7 +47,6 @@ public: > std::list<Request *> queuedRequests_; > ControlInfoMap controlInfo_; > ControlList properties_; > - std::unique_ptr<IPAProxy> ipa_; > > private: > CameraData(const CameraData &) = delete; > -- > 2.27.0 > > _______________________________________________ > libcamera-devel mailing list > libcamera-devel@lists.libcamera.org > https://lists.libcamera.org/listinfo/libcamera-devel
diff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h index a4e1b529..2018bef0 100644 --- a/include/libcamera/internal/pipeline_handler.h +++ b/include/libcamera/internal/pipeline_handler.h @@ -47,7 +47,6 @@ public: std::list<Request *> queuedRequests_; ControlInfoMap controlInfo_; ControlList properties_; - std::unique_ptr<IPAProxy> ipa_; private: CameraData(const CameraData &) = delete;
Since pipline handlers now have their own IPA interface types, it can no longer be defined in the base class, and each pipline handler implementation must declare it and its type themselves. Remove it from the base class. Signed-off-by: Paul Elder <paul.elder@ideasonboard.com> --- include/libcamera/internal/pipeline_handler.h | 1 - 1 file changed, 1 deletion(-)