| Message ID | 20200915142038.28757-11-paul.elder@ideasonboard.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series |
|
| Related | show |
Hi Paul, Thanks for your patch. On 2020-09-15 23:20:25 +0900, Paul Elder wrote: > Since stop() is part of the IPA interface, and the IPA interface is now > generated based on the data definition file per pipeline, this no longer > needs to be overrided by the base IPAProxy. Remove it. > > Signed-off-by: Paul Elder <paul.elder@ideasonboard.com> Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se> > --- > include/libcamera/internal/ipa_proxy.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/include/libcamera/internal/ipa_proxy.h b/include/libcamera/internal/ipa_proxy.h > index b429ce5a..aec8f04f 100644 > --- a/include/libcamera/internal/ipa_proxy.h > +++ b/include/libcamera/internal/ipa_proxy.h > @@ -27,8 +27,6 @@ public: > > std::string configurationFile(const std::string &file) const; > > - void stop() override = 0; > - > protected: > std::string resolvePath(const std::string &file) const; > > -- > 2.27.0 > > _______________________________________________ > libcamera-devel mailing list > libcamera-devel@lists.libcamera.org > https://lists.libcamera.org/listinfo/libcamera-devel
diff --git a/include/libcamera/internal/ipa_proxy.h b/include/libcamera/internal/ipa_proxy.h index b429ce5a..aec8f04f 100644 --- a/include/libcamera/internal/ipa_proxy.h +++ b/include/libcamera/internal/ipa_proxy.h @@ -27,8 +27,6 @@ public: std::string configurationFile(const std::string &file) const; - void stop() override = 0; - protected: std::string resolvePath(const std::string &file) const;
Since stop() is part of the IPA interface, and the IPA interface is now generated based on the data definition file per pipeline, this no longer needs to be overrided by the base IPAProxy. Remove it. Signed-off-by: Paul Elder <paul.elder@ideasonboard.com> --- include/libcamera/internal/ipa_proxy.h | 2 -- 1 file changed, 2 deletions(-)