| Message ID | 20200915142038.28757-12-paul.elder@ideasonboard.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series |
|
| Related | show |
Hi Paul, Thanks for your patch. On 2020-09-15 23:20:26 +0900, Paul Elder wrote: > Since IPAProxy implementations now always encapsulate IPA modules, add a > parameter to create() to signal if the proxy should isolate the IPA or not. > > Signed-off-by: Paul Elder <paul.elder@ideasonboard.com> > --- > include/libcamera/internal/ipa_proxy.h | 22 +++++++++++----------- > 1 file changed, 11 insertions(+), 11 deletions(-) > > diff --git a/include/libcamera/internal/ipa_proxy.h b/include/libcamera/internal/ipa_proxy.h > index aec8f04f..1903150e 100644 > --- a/include/libcamera/internal/ipa_proxy.h > +++ b/include/libcamera/internal/ipa_proxy.h > @@ -42,7 +42,7 @@ public: > IPAProxyFactory(const char *name); > virtual ~IPAProxyFactory() {} > > - virtual std::unique_ptr<IPAProxy> create(IPAModule *ipam) = 0; > + virtual std::unique_ptr<IPAProxy> create(IPAModule *ipam, bool isolate) = 0; With the isolate argument document in ipa_proxy.cpp, Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se> > > const std::string &name() const { return name_; } > > @@ -53,16 +53,16 @@ private: > std::string name_; > }; > > -#define REGISTER_IPA_PROXY(proxy) \ > -class proxy##Factory final : public IPAProxyFactory \ > -{ \ > -public: \ > - proxy##Factory() : IPAProxyFactory(#proxy) {} \ > - std::unique_ptr<IPAProxy> create(IPAModule *ipam) \ > - { \ > - return std::make_unique<proxy>(ipam); \ > - } \ > -}; \ > +#define REGISTER_IPA_PROXY(proxy) \ > +class proxy##Factory final : public IPAProxyFactory \ > +{ \ > +public: \ > + proxy##Factory() : IPAProxyFactory(#proxy) {} \ > + std::unique_ptr<IPAProxy> create(IPAModule *ipam, bool isolate) \ > + { \ > + return std::make_unique<proxy>(ipam, isolate); \ > + } \ > +}; \ > static proxy##Factory global_##proxy##Factory; > > } /* namespace libcamera */ > -- > 2.27.0 > > _______________________________________________ > libcamera-devel mailing list > libcamera-devel@lists.libcamera.org > https://lists.libcamera.org/listinfo/libcamera-devel
diff --git a/include/libcamera/internal/ipa_proxy.h b/include/libcamera/internal/ipa_proxy.h index aec8f04f..1903150e 100644 --- a/include/libcamera/internal/ipa_proxy.h +++ b/include/libcamera/internal/ipa_proxy.h @@ -42,7 +42,7 @@ public: IPAProxyFactory(const char *name); virtual ~IPAProxyFactory() {} - virtual std::unique_ptr<IPAProxy> create(IPAModule *ipam) = 0; + virtual std::unique_ptr<IPAProxy> create(IPAModule *ipam, bool isolate) = 0; const std::string &name() const { return name_; } @@ -53,16 +53,16 @@ private: std::string name_; }; -#define REGISTER_IPA_PROXY(proxy) \ -class proxy##Factory final : public IPAProxyFactory \ -{ \ -public: \ - proxy##Factory() : IPAProxyFactory(#proxy) {} \ - std::unique_ptr<IPAProxy> create(IPAModule *ipam) \ - { \ - return std::make_unique<proxy>(ipam); \ - } \ -}; \ +#define REGISTER_IPA_PROXY(proxy) \ +class proxy##Factory final : public IPAProxyFactory \ +{ \ +public: \ + proxy##Factory() : IPAProxyFactory(#proxy) {} \ + std::unique_ptr<IPAProxy> create(IPAModule *ipam, bool isolate) \ + { \ + return std::make_unique<proxy>(ipam, isolate); \ + } \ +}; \ static proxy##Factory global_##proxy##Factory; } /* namespace libcamera */
Since IPAProxy implementations now always encapsulate IPA modules, add a parameter to create() to signal if the proxy should isolate the IPA or not. Signed-off-by: Paul Elder <paul.elder@ideasonboard.com> --- include/libcamera/internal/ipa_proxy.h | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-)