[RFC,v3,25/50] ipa: libipa: agc: Adjust debug messages slightly
diff mbox series

Message ID 20260803131435.153927-26-barnabas.pocze@ideasonboard.com
State New
Headers show
Series
  • ipa: libipa: agc rework
Related show

Commit Message

Barnabás Pőcze Aug. 3, 2026, 1:14 p.m. UTC 
The log message showing the result of AGC seems too verbose to me,
and the labels and values are far from each other. And also log the
line duration when showing exposure and gain limits.

Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
---
 src/ipa/libipa/agc.cpp | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

Patch
diff mbox series 

diff --git a/src/ipa/libipa/agc.cpp b/src/ipa/libipa/agc.cpp
index 78a938568c..5273c1f64b 100644
--- a/src/ipa/libipa/agc.cpp
+++ b/src/ipa/libipa/agc.cpp
@@ -272,8 +272,10 @@  int AgcAlgorithm::configure(agc::Session &session, agc::ActiveState &state,
 	float defGain = config.sensor->gain(v4l2Gain.def().get<int32_t>());
 
 	LOG(Agc, Debug)
-		<< "Exposure: [" << minExposure << ", " << maxExposure
-		<< "], gain: [" << minGain << ", " << maxGain << "]";
+		<< "exposure:[" << minExposure << ',' << maxExposure << ']'
+		<< " gain:[" << minGain << ',' << maxGain << ']'
+		<< " line-duration:" << session.lineDuration
+		<< " sensor-output:" << session.sensor.outputSize;
 
 	/*
 	 * Compute the frame duration limits.
@@ -601,10 +603,10 @@  void AgcAlgorithm::process(const agc::Session &session, agc::ActiveState &state,
 		newExposureTime = newEv.exposureTime;
 
 		LOG(Agc, Debug)
-			<< "Divided up exposure time, analogue gain, quantization gain"
-			<< " and digital gain are " << utils::Duration(state.automatic.exposure * lineDuration)
-			<< ", " << state.automatic.gain << ", " << state.automatic.quantizationGain
-			<< " and " << newEv.digitalGain;
+			<< "exposure-time:" << utils::Duration(state.automatic.exposure * lineDuration)
+			<< " analogue-gain:" << state.automatic.gain
+			<< " quantization-gain:" << state.automatic.quantizationGain
+			<< " digital-gain:" << newEv.digitalGain;
 	}
 
 	/*