[RFC,v3,01/50] libcamera: software_isp: init(): Fix documentation typo
diff mbox series

Message ID 20260803131435.153927-2-barnabas.pocze@ideasonboard.com
State Superseded
Headers show
Series
  • ipa: libipa: agc rework
Related show

Commit Message

Barnabás Pőcze Aug. 3, 2026, 1:13 p.m. UTC
Don't break the parameter description.

Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
---
 src/libcamera/software_isp/software_isp.cpp | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Milan Zamazal Aug. 4, 2026, 8:16 a.m. UTC | #1
Barnabás Pőcze <barnabas.pocze@ideasonboard.com> writes:

> Don't break the parameter description.
>
> Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>

Reviewed-by: Milan Zamazal <mzamazal@redhat.com>

> ---
>  src/libcamera/software_isp/software_isp.cpp | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp
> index c73a16ce0a..f6b345f6a5 100644
> --- a/src/libcamera/software_isp/software_isp.cpp
> +++ b/src/libcamera/software_isp/software_isp.cpp
> @@ -75,9 +75,8 @@ LOG_DEFINE_CATEGORY(SoftwareIsp)
>  /**
>   * \brief Constructs SoftwareIsp object
>   * \param[in] pipe The pipeline handler in use
> - * \param[in] sensor Pointer to the CameraSensor instance owned by the pipeline
> + * \param[in] sensor Pointer to the CameraSensor instance owned by the pipeline handler
>   * \param[out] ipaControls The IPA controls to update
> - * handler
>   */
>  SoftwareIsp::SoftwareIsp(PipelineHandler *pipe, const CameraSensor *sensor,
>  			 ControlInfoMap *ipaControls)
Jacopo Mondi Aug. 5, 2026, 1:43 p.m. UTC | #2
Hi Barnabás

On Mon, Aug 03, 2026 at 03:13:46PM +0200, Barnabás Pőcze wrote:
> Don't break the parameter description.
>
> Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>

Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>

Thanks
  j

> ---
>  src/libcamera/software_isp/software_isp.cpp | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp
> index c73a16ce0a..f6b345f6a5 100644
> --- a/src/libcamera/software_isp/software_isp.cpp
> +++ b/src/libcamera/software_isp/software_isp.cpp
> @@ -75,9 +75,8 @@ LOG_DEFINE_CATEGORY(SoftwareIsp)
>  /**
>   * \brief Constructs SoftwareIsp object
>   * \param[in] pipe The pipeline handler in use
> - * \param[in] sensor Pointer to the CameraSensor instance owned by the pipeline
> + * \param[in] sensor Pointer to the CameraSensor instance owned by the pipeline handler
>   * \param[out] ipaControls The IPA controls to update
> - * handler
>   */
>  SoftwareIsp::SoftwareIsp(PipelineHandler *pipe, const CameraSensor *sensor,
>  			 ControlInfoMap *ipaControls)
> --
> 2.55.0
>

Patch
diff mbox series

diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp
index c73a16ce0a..f6b345f6a5 100644
--- a/src/libcamera/software_isp/software_isp.cpp
+++ b/src/libcamera/software_isp/software_isp.cpp
@@ -75,9 +75,8 @@  LOG_DEFINE_CATEGORY(SoftwareIsp)
 /**
  * \brief Constructs SoftwareIsp object
  * \param[in] pipe The pipeline handler in use
- * \param[in] sensor Pointer to the CameraSensor instance owned by the pipeline
+ * \param[in] sensor Pointer to the CameraSensor instance owned by the pipeline handler
  * \param[out] ipaControls The IPA controls to update
- * handler
  */
 SoftwareIsp::SoftwareIsp(PipelineHandler *pipe, const CameraSensor *sensor,
 			 ControlInfoMap *ipaControls)