| Message ID | 20260803131435.153927-23-barnabas.pocze@ideasonboard.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series |
|
| Related | show |
Hi Barnabás On Mon, Aug 03, 2026 at 03:14:07PM +0200, Barnabás Pőcze wrote: > `AgcMeanLuminance::setLimits()` is only required to be called before > `calculateNewEv()`, so the call in `configure()` has no real effect > because no calculation is carried out. So remove it. > > Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com> Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> > --- > src/ipa/libipa/agc.cpp | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/src/ipa/libipa/agc.cpp b/src/ipa/libipa/agc.cpp > index a8f91f864e..d751a8b0b8 100644 > --- a/src/ipa/libipa/agc.cpp > +++ b/src/ipa/libipa/agc.cpp > @@ -313,9 +313,6 @@ int AgcAlgorithm::configure(agc::Session &session, agc::ActiveState &state, > session.maxFrameDuration = std::chrono::microseconds(frameDurations[1]); > > impl_.configure(session.lineDuration, config.sensor); > - impl_.setLimits(session.minExposureTime, session.maxExposureTime, > - session.minAnalogueGain, session.maxAnalogueGain, > - {}); > impl_.resetFrameCount(); > > /* Configure the default exposure and gain. */ > -- > 2.55.0 >
diff --git a/src/ipa/libipa/agc.cpp b/src/ipa/libipa/agc.cpp index a8f91f864e..d751a8b0b8 100644 --- a/src/ipa/libipa/agc.cpp +++ b/src/ipa/libipa/agc.cpp @@ -313,9 +313,6 @@ int AgcAlgorithm::configure(agc::Session &session, agc::ActiveState &state, session.maxFrameDuration = std::chrono::microseconds(frameDurations[1]); impl_.configure(session.lineDuration, config.sensor); - impl_.setLimits(session.minExposureTime, session.maxExposureTime, - session.minAnalogueGain, session.maxAnalogueGain, - {}); impl_.resetFrameCount(); /* Configure the default exposure and gain. */
`AgcMeanLuminance::setLimits()` is only required to be called before `calculateNewEv()`, so the call in `configure()` has no real effect because no calculation is carried out. So remove it. Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com> --- src/ipa/libipa/agc.cpp | 3 --- 1 file changed, 3 deletions(-)