[v1,09/33] libcamera: converter_v4l2_m2m: Always set stride
diff mbox series

Message ID 20250930122726.1837524-10-stefan.klug@ideasonboard.com
State New
Headers show
Series
  • Full dewarper support on imx8mp
Related show

Commit Message

Stefan Klug Sept. 30, 2025, 12:26 p.m. UTC 
Ensure the stride is properly set after a call to validateOutput().

Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>
---
 src/libcamera/converter/converter_v4l2_m2m.cpp | 1 +
 1 file changed, 1 insertion(+)

Comments

Kieran Bingham Oct. 2, 2025, 10:07 p.m. UTC | #1 
Quoting Stefan Klug (2025-09-30 13:26:30)
> Ensure the stride is properly set after a call to validateOutput().
> 

Well this one seems easy and reasonable ;-)


Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>
> ---
>  src/libcamera/converter/converter_v4l2_m2m.cpp | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/libcamera/converter/converter_v4l2_m2m.cpp b/src/libcamera/converter/converter_v4l2_m2m.cpp
> index c6153d728c9a..e57db8a438ab 100644
> --- a/src/libcamera/converter/converter_v4l2_m2m.cpp
> +++ b/src/libcamera/converter/converter_v4l2_m2m.cpp
> @@ -680,6 +680,7 @@ int V4L2M2MConverter::validateOutput(StreamConfiguration *cfg, bool *adjusted,
>  
>         const Size cfgSize = cfg->size;
>         cfg->size = adjustSizes(cfgSize, it->second, align);
> +       cfg->stride = PixelFormatInfo::info(cfg->pixelFormat).stride(cfg->size.width, 0);
>  
>         if (cfg->size.isNull())
>                 return -EINVAL;
> -- 
> 2.48.1
>

Patch
diff mbox series 

diff --git a/src/libcamera/converter/converter_v4l2_m2m.cpp b/src/libcamera/converter/converter_v4l2_m2m.cpp
index c6153d728c9a..e57db8a438ab 100644
--- a/src/libcamera/converter/converter_v4l2_m2m.cpp
+++ b/src/libcamera/converter/converter_v4l2_m2m.cpp
@@ -680,6 +680,7 @@  int V4L2M2MConverter::validateOutput(StreamConfiguration *cfg, bool *adjusted,
 
 	const Size cfgSize = cfg->size;
 	cfg->size = adjustSizes(cfgSize, it->second, align);
+	cfg->stride = PixelFormatInfo::info(cfg->pixelFormat).stride(cfg->size.width, 0);
 
 	if (cfg->size.isNull())
 		return -EINVAL;