[libcamera-devel,10/10] libcamera: pipeline: Drop forward declaration of BufferPool

Message ID 20191028022224.795355-11-niklas.soderlund@ragnatech.se
State Accepted
Headers show
Series
  • libcamera: Fixes found while working on new buffer API
Related show

Commit Message

Niklas Söderlund Oct. 28, 2019, 2:22 a.m. UTC
There is no need to forward declare BufferPool, drop it.

Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
---
 src/libcamera/include/pipeline_handler.h | 1 -
 1 file changed, 1 deletion(-)

Comments

Laurent Pinchart Nov. 18, 2019, 11:30 a.m. UTC | #1
Hi Niklas,

Thank you for the patch.

On Mon, Oct 28, 2019 at 03:22:24AM +0100, Niklas Söderlund wrote:
> There is no need to forward declare BufferPool, drop it.
> 
> Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  src/libcamera/include/pipeline_handler.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/src/libcamera/include/pipeline_handler.h b/src/libcamera/include/pipeline_handler.h
> index 42b90a4bf1a6e414..320740746bc6e998 100644
> --- a/src/libcamera/include/pipeline_handler.h
> +++ b/src/libcamera/include/pipeline_handler.h
> @@ -21,7 +21,6 @@
>  namespace libcamera {
>  
>  class Buffer;
> -class BufferPool;
>  class Camera;
>  class CameraConfiguration;
>  class CameraManager;

Patch

diff --git a/src/libcamera/include/pipeline_handler.h b/src/libcamera/include/pipeline_handler.h
index 42b90a4bf1a6e414..320740746bc6e998 100644
--- a/src/libcamera/include/pipeline_handler.h
+++ b/src/libcamera/include/pipeline_handler.h
@@ -21,7 +21,6 @@ 
 namespace libcamera {
 
 class Buffer;
-class BufferPool;
 class Camera;
 class CameraConfiguration;
 class CameraManager;