[libcamera-devel,02/10] libcamera: buffer: Plane: Drop friend statement

Message ID 20191028022224.795355-3-niklas.soderlund@ragnatech.se
State Accepted
Headers show
Series
  • libcamera: Fixes found while working on new buffer API
Related show

Commit Message

Niklas Söderlund Oct. 28, 2019, 2:22 a.m. UTC
The Plane class do not need to friend Stream, drop it.

Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
---
 include/libcamera/buffer.h | 2 --
 1 file changed, 2 deletions(-)

Comments

Laurent Pinchart Nov. 18, 2019, 11:17 a.m. UTC | #1
Hi Niklas,

Thank you for the patch.

On Mon, Oct 28, 2019 at 03:22:16AM +0100, Niklas Söderlund wrote:
> The Plane class do not need to friend Stream, drop it.
> 
> Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  include/libcamera/buffer.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/include/libcamera/buffer.h b/include/libcamera/buffer.h
> index e14c9bd390a13bfc..d7784d9d24ab3f41 100644
> --- a/include/libcamera/buffer.h
> +++ b/include/libcamera/buffer.h
> @@ -29,8 +29,6 @@ public:
>  	unsigned int length() const { return length_; }
>  
>  private:
> -	friend class Stream;
> -
>  	int mmap();
>  	int munmap();
>

Patch

diff --git a/include/libcamera/buffer.h b/include/libcamera/buffer.h
index e14c9bd390a13bfc..d7784d9d24ab3f41 100644
--- a/include/libcamera/buffer.h
+++ b/include/libcamera/buffer.h
@@ -29,8 +29,6 @@  public:
 	unsigned int length() const { return length_; }
 
 private:
-	friend class Stream;
-
 	int mmap();
 	int munmap();