[libcamera-devel,03/10] libcamera: buffer: Drop friend statment

Message ID 20191028022224.795355-4-niklas.soderlund@ragnatech.se
State Superseded
Delegated to: Niklas Söderlund
Headers show
Series
  • libcamera: Fixes found while working on new buffer API
Related show

Commit Message

Niklas Söderlund Oct. 28, 2019, 2:22 a.m. UTC
The Buffer class do not need to friend PipelineHandler, drop it.

Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
---
 include/libcamera/buffer.h | 1 -
 1 file changed, 1 deletion(-)

Comments

Laurent Pinchart Nov. 18, 2019, 11:19 a.m. UTC | #1
Hi Niklas,

Thank you for the patch.

On Mon, Oct 28, 2019 at 03:22:17AM +0100, Niklas Söderlund wrote:
> The Buffer class do not need to friend PipelineHandler, drop it.
> 
> Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  include/libcamera/buffer.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/include/libcamera/buffer.h b/include/libcamera/buffer.h
> index d7784d9d24ab3f41..c349b995e1eb35ee 100644
> --- a/include/libcamera/buffer.h
> +++ b/include/libcamera/buffer.h
> @@ -88,7 +88,6 @@ public:
>  
>  private:
>  	friend class Camera;
> -	friend class PipelineHandler;
>  	friend class Request;
>  	friend class Stream;
>  	friend class V4L2VideoDevice;

Patch

diff --git a/include/libcamera/buffer.h b/include/libcamera/buffer.h
index d7784d9d24ab3f41..c349b995e1eb35ee 100644
--- a/include/libcamera/buffer.h
+++ b/include/libcamera/buffer.h
@@ -88,7 +88,6 @@  public:
 
 private:
 	friend class Camera;
-	friend class PipelineHandler;
 	friend class Request;
 	friend class Stream;
 	friend class V4L2VideoDevice;