[RFC,v1,04/12] apps: lc-compliance: Remove redundant getter call
diff mbox series

Message ID 20241220150759.709756-5-pobrn@protonmail.com
State Superseded
Headers show
Series
  • apps: lc-compliance: Multi-stream tests
Related show

Commit Message

Barnabás Pőcze Dec. 20, 2024, 3:08 p.m. UTC 
Smart pointers overload `operator->()`, no reason to use `get()`.

Signed-off-by: Barnabás Pőcze <pobrn@protonmail.com>
---
 src/apps/lc-compliance/main.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jacopo Mondi Jan. 7, 2025, 4:31 p.m. UTC | #1 
Hi Barnabás

On Fri, Dec 20, 2024 at 03:08:20PM +0000, Barnabás Pőcze wrote:
> Smart pointers overload `operator->()`, no reason to use `get()`.
>
> Signed-off-by: Barnabás Pőcze <pobrn@protonmail.com>

indeed
Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>

Thanks
  j

> ---
>  src/apps/lc-compliance/main.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/apps/lc-compliance/main.cpp b/src/apps/lc-compliance/main.cpp
> index 98f2573d0..cdd0bd515 100644
> --- a/src/apps/lc-compliance/main.cpp
> +++ b/src/apps/lc-compliance/main.cpp
> @@ -45,7 +45,7 @@ class ThrowListener : public testing::EmptyTestEventListener
>  static void listCameras(CameraManager *cm)
>  {
>  	for (const std::shared_ptr<Camera> &cam : cm->cameras())
> -		std::cout << "- " << cam.get()->id() << std::endl;
> +		std::cout << "- " << cam->id() << std::endl;
>  }
>
>  static int initCamera(CameraManager *cm, OptionsParser::Options options)
> --
> 2.47.1
>
>
Paul Elder Jan. 9, 2025, 10:16 p.m. UTC | #2 
On Fri, Dec 20, 2024 at 03:08:20PM +0000, Barnabás Pőcze wrote:
> Smart pointers overload `operator->()`, no reason to use `get()`.
> 
> Signed-off-by: Barnabás Pőcze <pobrn@protonmail.com>

Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>

> ---
>  src/apps/lc-compliance/main.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/apps/lc-compliance/main.cpp b/src/apps/lc-compliance/main.cpp
> index 98f2573d0..cdd0bd515 100644
> --- a/src/apps/lc-compliance/main.cpp
> +++ b/src/apps/lc-compliance/main.cpp
> @@ -45,7 +45,7 @@ class ThrowListener : public testing::EmptyTestEventListener
>  static void listCameras(CameraManager *cm)
>  {
>  	for (const std::shared_ptr<Camera> &cam : cm->cameras())
> -		std::cout << "- " << cam.get()->id() << std::endl;
> +		std::cout << "- " << cam->id() << std::endl;
>  }
>  
>  static int initCamera(CameraManager *cm, OptionsParser::Options options)
> -- 
> 2.47.1
> 
>

Patch
diff mbox series 

diff --git a/src/apps/lc-compliance/main.cpp b/src/apps/lc-compliance/main.cpp
index 98f2573d0..cdd0bd515 100644
--- a/src/apps/lc-compliance/main.cpp
+++ b/src/apps/lc-compliance/main.cpp
@@ -45,7 +45,7 @@  class ThrowListener : public testing::EmptyTestEventListener
 static void listCameras(CameraManager *cm)
 {
 	for (const std::shared_ptr<Camera> &cam : cm->cameras())
-		std::cout << "- " << cam.get()->id() << std::endl;
+		std::cout << "- " << cam->id() << std::endl;
 }
 
 static int initCamera(CameraManager *cm, OptionsParser::Options options)