[RFC,v1,01/12] apps: lc-compliance: Initialize `CameraManager` pointer in `Environment`
diff mbox series

Message ID 20241220150759.709756-2-pobrn@protonmail.com
State Superseded
Headers show
Series
  • apps: lc-compliance: Multi-stream tests
Related show

Commit Message

Barnabás Pőcze Dec. 20, 2024, 3:08 p.m. UTC 
Do not leave it unitialized.

Signed-off-by: Barnabás Pőcze <pobrn@protonmail.com>
---
 src/apps/lc-compliance/environment.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jacopo Mondi Jan. 7, 2025, 4:27 p.m. UTC | #1 
Hi Barnabas,
   surely doesn't hurt

Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>

On Fri, Dec 20, 2024 at 03:08:08PM +0000, Barnabás Pőcze wrote:
> Do not leave it unitialized.
>
> Signed-off-by: Barnabás Pőcze <pobrn@protonmail.com>
> ---
>  src/apps/lc-compliance/environment.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/apps/lc-compliance/environment.h b/src/apps/lc-compliance/environment.h
> index 543e5372f..834c722ef 100644
> --- a/src/apps/lc-compliance/environment.h
> +++ b/src/apps/lc-compliance/environment.h
> @@ -23,5 +23,5 @@ private:
>  	Environment() = default;
>
>  	std::string cameraId_;
> -	libcamera::CameraManager *cm_;
> +	libcamera::CameraManager *cm_ = nullptr;
>  };
> --
> 2.47.1
>
>
Paul Elder Jan. 9, 2025, 10:15 p.m. UTC | #2 
On Fri, Dec 20, 2024 at 03:08:08PM +0000, Barnabás Pőcze wrote:
> Do not leave it unitialized.
> 
> Signed-off-by: Barnabás Pőcze <pobrn@protonmail.com>

Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>

> ---
>  src/apps/lc-compliance/environment.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/apps/lc-compliance/environment.h b/src/apps/lc-compliance/environment.h
> index 543e5372f..834c722ef 100644
> --- a/src/apps/lc-compliance/environment.h
> +++ b/src/apps/lc-compliance/environment.h
> @@ -23,5 +23,5 @@ private:
>  	Environment() = default;
>  
>  	std::string cameraId_;
> -	libcamera::CameraManager *cm_;
> +	libcamera::CameraManager *cm_ = nullptr;
>  };
> -- 
> 2.47.1
> 
>

Patch
diff mbox series 

diff --git a/src/apps/lc-compliance/environment.h b/src/apps/lc-compliance/environment.h
index 543e5372f..834c722ef 100644
--- a/src/apps/lc-compliance/environment.h
+++ b/src/apps/lc-compliance/environment.h
@@ -23,5 +23,5 @@  private:
 	Environment() = default;
 
 	std::string cameraId_;
-	libcamera::CameraManager *cm_;
+	libcamera::CameraManager *cm_ = nullptr;
 };