| Message ID | 20241220150759.709756-3-pobrn@protonmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series |
|
| Related | show |
Hi Barnabás On Fri, Dec 20, 2024 at 03:08:12PM +0000, Barnabás Pőcze wrote: > There is no reason for these symbols to be global. > > Signed-off-by: Barnabás Pőcze <pobrn@protonmail.com> Likewise Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> Thanks j > --- > src/apps/lc-compliance/tests/capture_test.cpp | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/src/apps/lc-compliance/tests/capture_test.cpp b/src/apps/lc-compliance/tests/capture_test.cpp > index ad3a1da2f..db196a949 100644 > --- a/src/apps/lc-compliance/tests/capture_test.cpp > +++ b/src/apps/lc-compliance/tests/capture_test.cpp > @@ -14,6 +14,8 @@ > > #include "environment.h" > > +namespace { > + > using namespace libcamera; > > const std::vector<int> NUMREQUESTS = { 1, 2, 3, 5, 8, 13, 21, 34, 55, 89 }; > @@ -134,3 +136,5 @@ INSTANTIATE_TEST_SUITE_P(CaptureTests, > testing::Combine(testing::ValuesIn(ROLES), > testing::ValuesIn(NUMREQUESTS)), > SingleStream::nameParameters); > + > +} /* namespace */ > -- > 2.47.1 > >
On Fri, Dec 20, 2024 at 03:08:12PM +0000, Barnabás Pőcze wrote: > There is no reason for these symbols to be global. > > Signed-off-by: Barnabás Pőcze <pobrn@protonmail.com> Reviewed-by: Paul Elder <paul.elder@ideasonboard.com> > --- > src/apps/lc-compliance/tests/capture_test.cpp | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/src/apps/lc-compliance/tests/capture_test.cpp b/src/apps/lc-compliance/tests/capture_test.cpp > index ad3a1da2f..db196a949 100644 > --- a/src/apps/lc-compliance/tests/capture_test.cpp > +++ b/src/apps/lc-compliance/tests/capture_test.cpp > @@ -14,6 +14,8 @@ > > #include "environment.h" > > +namespace { > + > using namespace libcamera; > > const std::vector<int> NUMREQUESTS = { 1, 2, 3, 5, 8, 13, 21, 34, 55, 89 }; > @@ -134,3 +136,5 @@ INSTANTIATE_TEST_SUITE_P(CaptureTests, > testing::Combine(testing::ValuesIn(ROLES), > testing::ValuesIn(NUMREQUESTS)), > SingleStream::nameParameters); > + > +} /* namespace */ > -- > 2.47.1 > >
diff --git a/src/apps/lc-compliance/tests/capture_test.cpp b/src/apps/lc-compliance/tests/capture_test.cpp index ad3a1da2f..db196a949 100644 --- a/src/apps/lc-compliance/tests/capture_test.cpp +++ b/src/apps/lc-compliance/tests/capture_test.cpp @@ -14,6 +14,8 @@ #include "environment.h" +namespace { + using namespace libcamera; const std::vector<int> NUMREQUESTS = { 1, 2, 3, 5, 8, 13, 21, 34, 55, 89 }; @@ -134,3 +136,5 @@ INSTANTIATE_TEST_SUITE_P(CaptureTests, testing::Combine(testing::ValuesIn(ROLES), testing::ValuesIn(NUMREQUESTS)), SingleStream::nameParameters); + +} /* namespace */
There is no reason for these symbols to be global. Signed-off-by: Barnabás Pőcze <pobrn@protonmail.com> --- src/apps/lc-compliance/tests/capture_test.cpp | 4 ++++ 1 file changed, 4 insertions(+)