[libcamera-devel,v3,2/5] libcamera: converter: drop unnecessary #include directive
diff mbox series

Message ID 20230928185537.20178-3-andrey.konovalov@linaro.org
State Accepted
Headers show
Series
  • libcamera: converter: generalize Converter to remove MediaDevice dependency
Related show

Commit Message

Andrey Konovalov Sept. 28, 2023, 6:55 p.m. UTC 
libcamera/internal/media_device.h includes linux/media.h already.

Signed-off-by: Andrey Konovalov <andrey.konovalov@linaro.org>
Suggested-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
---
 src/libcamera/converter.cpp | 2 --
 1 file changed, 2 deletions(-)

Comments

Mattijs Korpershoek Sept. 30, 2023, 8:50 a.m. UTC | #1 
On jeu., sept. 28, 2023 at 21:55, Andrey Konovalov <andrey.konovalov@linaro.org> wrote:

> libcamera/internal/media_device.h includes linux/media.h already.
>
> Signed-off-by: Andrey Konovalov <andrey.konovalov@linaro.org>
> Suggested-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>

Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>

> ---
>  src/libcamera/converter.cpp | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/src/libcamera/converter.cpp b/src/libcamera/converter.cpp
> index 15701363..aca4fbc7 100644
> --- a/src/libcamera/converter.cpp
> +++ b/src/libcamera/converter.cpp
> @@ -13,8 +13,6 @@
>  
>  #include "libcamera/internal/media_device.h"
>  
> -#include "linux/media.h"
> -
>  /**
>   * \file internal/converter.h
>   * \brief Abstract converter
> -- 
> 2.34.1
Laurent Pinchart Sept. 30, 2023, 9:16 a.m. UTC | #2 
Hi Andrey,

Thank you for the patch.

On Thu, Sep 28, 2023 at 09:55:34PM +0300, Andrey Konovalov via libcamera-devel wrote:
> libcamera/internal/media_device.h includes linux/media.h already.
> 
> Signed-off-by: Andrey Konovalov <andrey.konovalov@linaro.org>
> Suggested-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  src/libcamera/converter.cpp | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/src/libcamera/converter.cpp b/src/libcamera/converter.cpp
> index 15701363..aca4fbc7 100644
> --- a/src/libcamera/converter.cpp
> +++ b/src/libcamera/converter.cpp
> @@ -13,8 +13,6 @@
>  
>  #include "libcamera/internal/media_device.h"
>  
> -#include "linux/media.h"
> -
>  /**
>   * \file internal/converter.h
>   * \brief Abstract converter

Patch
diff mbox series 

diff --git a/src/libcamera/converter.cpp b/src/libcamera/converter.cpp
index 15701363..aca4fbc7 100644
--- a/src/libcamera/converter.cpp
+++ b/src/libcamera/converter.cpp
@@ -13,8 +13,6 @@ 
 
 #include "libcamera/internal/media_device.h"
 
-#include "linux/media.h"
-
 /**
  * \file internal/converter.h
  * \brief Abstract converter