| Message ID | 20230206170356.20340-4-laurent.pinchart@ideasonboard.com |
|---|---|
| State | Accepted |
| Commit | 9cc5cbadc2244560ea5325491acdb90e2bbbc196 |
| Headers | show |
| Series |
|
| Related | show |
Hi Laurent, Thank you for the patch On 2/6/23 10:33 PM, Laurent Pinchart via libcamera-devel wrote: > Commit 1a614866a29c ("libcamera: camera_sensor: Validate Transform") has > removed usage of the IPU3CameraData::rotationTransform_ but hasn't > removed the field itself, nor its initialization. Drop those as they're > unused. > > Fixes: 1a614866a29c ("libcamera: camera_sensor: Validate Transform") > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Umang Jain <umang.jain@ideasonboard.com> > --- > src/libcamera/pipeline/ipu3/ipu3.cpp | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp > index 3a569c7e0031..355cb0cb76b8 100644 > --- a/src/libcamera/pipeline/ipu3/ipu3.cpp > +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp > @@ -73,7 +73,6 @@ public: > Stream rawStream_; > > Rectangle cropRegion_; > - Transform rotationTransform_; > > std::unique_ptr<DelayedControls> delayedCtrls_; > IPU3Frames frameInfos_; > @@ -1101,13 +1100,6 @@ int PipelineHandlerIPU3::registerCameras() > << cio2->sensor()->id() > << ". Assume rotation 0"; > > - int32_t rotationValue = rotation.value_or(0); > - bool success; > - data->rotationTransform_ = transformFromRotation(rotationValue, &success); > - if (!success) > - LOG(IPU3, Warning) << "Invalid rotation of " << rotationValue > - << " degrees: ignoring"; > - > /** > * \todo Dynamically assign ImgU and output devices to each > * stream and camera; as of now, limit support to two cameras
diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp index 3a569c7e0031..355cb0cb76b8 100644 --- a/src/libcamera/pipeline/ipu3/ipu3.cpp +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp @@ -73,7 +73,6 @@ public: Stream rawStream_; Rectangle cropRegion_; - Transform rotationTransform_; std::unique_ptr<DelayedControls> delayedCtrls_; IPU3Frames frameInfos_; @@ -1101,13 +1100,6 @@ int PipelineHandlerIPU3::registerCameras() << cio2->sensor()->id() << ". Assume rotation 0"; - int32_t rotationValue = rotation.value_or(0); - bool success; - data->rotationTransform_ = transformFromRotation(rotationValue, &success); - if (!success) - LOG(IPU3, Warning) << "Invalid rotation of " << rotationValue - << " degrees: ignoring"; - /** * \todo Dynamically assign ImgU and output devices to each * stream and camera; as of now, limit support to two cameras
Commit 1a614866a29c ("libcamera: camera_sensor: Validate Transform") has removed usage of the IPU3CameraData::rotationTransform_ but hasn't removed the field itself, nor its initialization. Drop those as they're unused. Fixes: 1a614866a29c ("libcamera: camera_sensor: Validate Transform") Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- src/libcamera/pipeline/ipu3/ipu3.cpp | 8 -------- 1 file changed, 8 deletions(-)